Code Monkey home page Code Monkey logo

Comments (6)

aherrmann avatar aherrmann commented on September 17, 2024 4

With flakes available now switching to flakes to provide nixpkgs may be a better option.

from rules_nixpkgs.

avdv avatar avdv commented on September 17, 2024 2

Hi @tshaynik ,

sorry, I have been also working on this, but did not get around to pushing until now...

Could you please have a look at PR #265 ?!

from rules_nixpkgs.

aherrmann avatar aherrmann commented on September 17, 2024 1

@tshaynik Nice, that would be a good change.
Beware that the are two layers to this. One is the Nix shell that provides Bazel, that should be reasonably straight forward, I expect. The other is the nixpkgs that's imported into Bazel using rules_nixpkgs. I think that's less straight forward, as rules_nixpkgs invokes nix-build and may need a compatibility layer access the nixpkgs attribute.
It may be better to split this task in two: One for the shell, and a separate one for importing nixpkgs from a flake.

from rules_nixpkgs.

tshaynik avatar tshaynik commented on September 17, 2024

I would be happy to work on switching the project over to using flakes!

from rules_nixpkgs.

tshaynik avatar tshaynik commented on September 17, 2024

Makes sense! I'll push a WIP pull request with the flake that provides the nix devShell today, and start looking into the more complex second part.
It will probably make sense to switch the invocation from the old nix-build to the flake-aware nix build as well.

from rules_nixpkgs.

aherrmann avatar aherrmann commented on September 17, 2024

It will probably make sense to switch the invocation from the old nix-build to the flake-aware nix build as well.

Yes, perhaps, if so, be sure to check if this has compatibility breaking consequences.

from rules_nixpkgs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.