Comments (12)
Yep -- this, along with ie8 support is already live in this branch: https://github.com/twitter/bootstrap/tree/misc_css_fixes
thanks however!
from bootstrap.
On second thought -- i'll leave this open until we merge that branch in. :)
from bootstrap.
IMO, better to use a wrapper than an empty div
that is positioned to provide the background.
The drop-down JS in that branch isn't going to work well if someone decides to have more than 1 dropdown option in the secondary nav and/or if you decide to pull the dropdown out into its own pattern.
from bootstrap.
Yep -- i agree -- that's what we're doing in that branch:
https://github.com/twitter/bootstrap/blob/misc_css_fixes/lib/patterns.less#L19
from bootstrap.
Also, the js is for demo purposes only -- we don't recommend anyone use any of the js.
You're of course welcome to check it out, but you really should be writing custom js for your particular application. In this case -- what's there is the simplest code for our given demo. :)
from bootstrap.
Yep -- i agree -- that's what we're doing in that branch:
Sorry, I think you misunderstood. I meant that a wrapper is probably preferable to an empty element...unless you've found some problems that it throws up.
you really should be writing custom js for your particular application
Ah, ok...CSS only. Should you not also be writing custom CSS ;) It would still be good to somehow decouple the dropdown pattern from the topbar pattern IMO. Although, that might not quite fit with your plans or aims this project.
from bootstrap.
Ahh gotcha. Yeah -- good point about the element, i'll switch it to a wrapper.
Yeah the drop down is an interesting bit - and it's might be worth trying to decouple it more. For now, i think it's simple enough and a nice addition though.
from bootstrap.
For sure. I'll have a look at doing it and let you know if anything fruitful comes of it. If nothing comes of it, I'll just pretend I didn't even try.
from bootstrap.
haha alright sounds good ;)
from bootstrap.
Is this what you were thinking with the wrapper?
from bootstrap.
Yeah pretty much...if it works
from bootstrap.
this is all live now !
from bootstrap.
Related Issues (20)
- Adding new SCSS variables for `letter-spacing` HOT 1
- Floating Labels for File Input
- Suggest a new feature
- input add min-inline-size:0;
- Modal of Bootstrap v5.3 did not work! HOT 1
- How RTL support works with Sass in Bootstrap.
- The dropdown is not working after updating navbar content using HTMX
- Define `$component-active-color` with `color-contrast()` HOT 1
- Active nav links with default style look inactive HOT 2
- Request for recovery of One Time Key
- docs: Improve install guide for modern use like in scss.
- Reduce CSS variable overrides for colors HOT 1
- Add a glass effect to dropdowns HOT 1
- Floating labels incorrectly positioned for inputs with autofill, but no value HOT 2
- Upon initial launch of the Bootstrap modal NVDA reads all the content of the modal
- System UI font not used on WebKit
- bootstrap
- Carousel More Gallery HOT 1
- Offcanvas - dispose() not reseting scrollbars
- overflow-x-scroll has an !important applied negating respinsive directives HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bootstrap.