Comments (8)
How about not specifying a sass dependency at all and leaving it up to the user to select the one that is appropriate for them?
from bootstrap-rubygem.
I don't use Rails much anymore but it sounds like migrating to dartsass-sprockets
would make sense.
I'm guessing that in the post-Sprockets Rails JavaScript world this gem simply isn't needed, as one can use the npm bootstrap package directly.
from bootstrap-rubygem.
I just want to chime in here with my experience.
I'm a maintainer over at OpenStreetMap and the dependency on sassc-rails
is blocking us from upgrading to bootstrap 5.2 . We are running into an issue where libsass can no longer parse it's own compressed output, with syntax that is used in bootstrap 5.2+, and that's causing problems while precompiling all our assets. More details on the exact syntax issue in this comment
Since libsass is dead, and the parsing problem is unlikely to be fixed there, I want to switch to dartsass-sprockets. But we can't since it's an either/or with sassc-rails vs dartsass-sprockets. And this gem has a hard runtime dependency on sassc-rails.
I'd be in favour of either proposed solution - either switching the dependency to dartsass-sprockets (as per #256), or figuring out how to drop the hardcoded sass engine dependency entirely (as per above comment). Either way, having a bootstrap-rubygem is still very useful for us, just not one that depends on a legacy unmaintained gem! 😄
from bootstrap-rubygem.
Maybe something like this?
begin
require 'dartsass-sprockets'
rescue LoadError
require 'sassc-rails'
rescue LoadError
raise LoadError.new("bootstrap-rubygem requires a Sass engine. Please add dartsass-sprockets or sassc-rails to your dependencies.")
end
from bootstrap-rubygem.
Yeah, I was thinking pretty much the same thing 👍
If no one is available on your team and if you're okay with this, I can try to fork and make the change there!
from bootstrap-rubygem.
Not having a hardcoded Sass dependency would be better I guess, but I don't really know how to write this in a smart and clean way :(
from bootstrap-rubygem.
Something clean to write here maybe if we want to declare Sass as a soft dependency and let the user pick between the two gems (other than removing the gem from the current dependencies)
from bootstrap-rubygem.
@SebouChu Yeah something along these lines would be ideal
from bootstrap-rubygem.
Related Issues (20)
- Bootstrap without sprockets HOT 18
- JS interactions not working when following the instructions in the README HOT 4
- Provide build for 5.3.0-alpha1 HOT 4
- Support for Bootstrap 5.3 HOT 1
- Gem "5.3.0-alpha1" does not exist as the document states in multiple places HOT 2
- Bootstrap 4.6.2 popper issue HOT 4
- Importmaps Documentation HOT 2
- Sass ABS deprecation warning for bootstrap-rubygem v 5.3.1 HOT 1
- Dynamic on the fly CSS generation
- Rubygems has latest of 5.3.1 and not 5.3.2 HOT 2
- Breaking change in 5.3.2: dropping dependencies HOT 3
- Update autoprefixer-rails dependency HOT 1
- Include ESM version?
- Main branch is ahead of rubygem’s gem, dartsass-rails is not included HOT 3
- Include bootstrap-icons HOT 1
- Rails default Dockerfile build failed after added bootstrap gem HOT 9
- New 4.6 release? HOT 1
- File to import not found or unreadable: bootstrap/scss/bootstrap
- Release 5.3.3 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bootstrap-rubygem.