Code Monkey home page Code Monkey logo

Comments (1)

tvcutsem avatar tvcutsem commented on May 27, 2024

You are right: if newTarget is different from target, we still need to call target, just with a custom instance. Unfortunately the newTarget option cannot be perfectly emulated in pure ES5 as there is no way to pass a custom newTarget to the [[Construct]] internal method of a function (well, the only way to do that is through Reflect.construct in ES6, but that's the precisely the method we are shimming)

I patched the method to continue to use the bound function approach when newTarget is not set (or is equal to target). The advantage being that this approach will work even if target is an ES6 class constructor function.

If newTarget is set, then we fall back to creating a custom instance and calling the target's [[Call]] internal method with the custom instance. This works for plain constructor functions, but will fail for ES6 class constructors as they must be invoked using the new operator.

Thanks for reporting!

from harmony-reflect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.