Respect X-Forwarded-Port and X-Forwarded-Prefix as well about tus-node-server HOT 2 CLOSED

Hi @olee
I think generally makes sense to have the port included if provided in the x-forwarded-port header, however, the x-forwarded-prefix header seems a less canonical header. Maybe some proxies might use it mostly they don't.

For these specific use cases where you need full control on how the generated url is constructed, you can use the generateUrl function on the server, for example:

const server = new Server({
  ...restOptions,
  generateUrl(req, {proto, host, path, id}) {
    const forwardPort = req.headers['x-forwarded-port']
    const forwardPrefix = req.headers['x-forwarded-prefix']
    
   host ??= forwardHost + (forwardPort ? `:${forwardPort}` : '') + (forwardPrefix ? forwardPrefix.slice(1, -1) : '')

    return `${proto}://${host}${path}/${id}`
  }
})

from tus-node-server.

I agree with @fenos, I prefer giving inversion of control so people can do whatever they want over supporting all kinds of internal conditions (of non-standard headers).

from tus-node-server.