Comments (3)
Oh, that's interesting - never realised that! I think my original intention with the string variant was to add some minor optimizations for .NET Framework which seemed irrelevant for .NET Core with ReadOnlySpan<char>
etc. Its definitely a good idea to re-evaluate whether that is truly useful and whether I don't just do as you've suggested and call the overload.
from quickenshtein.
Again, great catch for finding this issue, raising it and submitting a PR - I really appreciate it! Will release a new version with this change now!
from quickenshtein.
Hey @Turnerj, same thing here is happening but for netstandard2.1
. In my case, I am calling public unsafe static int GetDistance(ReadOnlySpan<char> source, ReadOnlySpan<char> target, CalculationOptions calculationOptions)
directly. There's no issue if I call Levenshtein.GetDistance(string, string)
instead.
from quickenshtein.
Related Issues (13)
- Improving Threading Calculation Performance
- Add k-threshold support HOT 1
- Re-look at Threading HOT 1
- Improving the Diagonal Calculation HOT 4
- Improving Instruction Level Dependency
- Branch Miss Analysis HOT 2
- Update BDN Columns HOT 1
- Identify "slowdown" with one of the two strings being empty HOT 2
- Benchmarking individual pieces of Quickenshtein
- Full-branchless Calculation with SIMD HOT 1
- feature: edit script HOT 1
- On .NET framework 4.8 this library is slower than super simple 1 file equivalent. Is that normal? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quickenshtein.