Code Monkey home page Code Monkey logo

Comments (3)

Turnerj avatar Turnerj commented on May 23, 2024

Oh, that's interesting - never realised that! I think my original intention with the string variant was to add some minor optimizations for .NET Framework which seemed irrelevant for .NET Core with ReadOnlySpan<char> etc. Its definitely a good idea to re-evaluate whether that is truly useful and whether I don't just do as you've suggested and call the overload.

from quickenshtein.

Turnerj avatar Turnerj commented on May 23, 2024

Again, great catch for finding this issue, raising it and submitting a PR - I really appreciate it! Will release a new version with this change now!

from quickenshtein.

winstxnhdw avatar winstxnhdw commented on May 23, 2024

Hey @Turnerj, same thing here is happening but for netstandard2.1. In my case, I am calling public unsafe static int GetDistance(ReadOnlySpan<char> source, ReadOnlySpan<char> target, CalculationOptions calculationOptions) directly. There's no issue if I call Levenshtein.GetDistance(string, string) instead.

from quickenshtein.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.