Code Monkey home page Code Monkey logo

Comments (8)

albertodiazsaez avatar albertodiazsaez commented on May 24, 2024

I think the list should be separated with , instead of +. In code it's easier to create a list of params separated with commas to construct the concat that with +, but keeping the simplified version you mentioned:

concat(firstName, ' ', lastName):'SearchTerm'

And, because spaces it's going to be very common for a concat, maybe a spaceConcat(firstName, lastName)that automatically adds spaces between fields?

I do not understand what you mean by numbers, it should be possible with concat('1', '2') to get 12, what is the advantage of concat(1,2)?

from springfilter.

torshid avatar torshid commented on May 24, 2024

Good suggestion. I think that the comma separator is a better option too. I will try to implement a generic solution soon.

from springfilter.

torshid avatar torshid commented on May 24, 2024

I am sorry for not being clear about 'numbers', it was supposed to be equivalent to the sum function when used with numbers, it has no relation to concatenation. :)

from springfilter.

albertodiazsaez avatar albertodiazsaez commented on May 24, 2024

No worries :P

I think it's confusing to use the concat() for two separated functions depending on the input.

I do not understand the functionality of it tho, if you put concat(1,2), what will be done with the resulting 3?

from springfilter.

torshid avatar torshid commented on May 24, 2024

No, numbers are not supposed to be used with the concat function, this one can only accept strings. :D
The + operator can possibly used with numbers for addition, and with strings for concatenation.

from springfilter.

albertodiazsaez avatar albertodiazsaez commented on May 24, 2024

Ah, ok, so using + when working with numbers in all the filters, right?

If that's the case, the other main operators (- / *) should work as well.

from springfilter.

torshid avatar torshid commented on May 24, 2024

Yes. You are right about implementing the other operators. But mathematical operations will have no use case I guess, so I am leaving this idea for now. I will only implement the commas for variadic functions.

from springfilter.

torshid avatar torshid commented on May 24, 2024

@albertodiazsaez Just released version https://github.com/turkraft/spring-filter/releases/tag/1.0.3, you may now do concat(firstName, ' ', lastName):'SearchTerm' :)

from springfilter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.