Code Monkey home page Code Monkey logo

Comments (12)

cpfiffer avatar cpfiffer commented on June 8, 2024 3

I think the process we should have is to do all the development in dev and cherry pick any bug fixes or quick fixes into master before a release, so that master doesn't change as much as it does now.

from dynamicppl.jl.

devmotion avatar devmotion commented on June 8, 2024 1

Since many commits affected the same files and functions, I guess it's also tricky to actually cherry pick commits and still ensure that nothing is broken and we don't reintroduce stuff that was removed at some point.

from dynamicppl.jl.

cpfiffer avatar cpfiffer commented on June 8, 2024 1

Nope, go for it.

from dynamicppl.jl.

devmotion avatar devmotion commented on June 8, 2024

Sounds reasonable, we started using the same setup for MCMCChains some time ago. However, it's not ideal yet, I noticed that we have a bunch of fixes in the master branch that are not included in the dev branch. I'm not sure what's the best way to handle it, maybe we should just merge master from time to time or cherrypick these commits? Or just merge the dev branch often enough 😄

from dynamicppl.jl.

mohamed82008 avatar mohamed82008 commented on June 8, 2024

I agree.

from dynamicppl.jl.

mohamed82008 avatar mohamed82008 commented on June 8, 2024

I will create a dev branch and reset master to the latest release then cherry-pick non-breaking changes.

from dynamicppl.jl.

devmotion avatar devmotion commented on June 8, 2024

Is this necessary, can't we just update Turing and start using a dev branch from now on? Many changes were just internal or should only affect Inference.jl. And AbstractMCMC 1.0 requires to update Inference.jl anyways.

from dynamicppl.jl.

mohamed82008 avatar mohamed82008 commented on June 8, 2024

Sounds good, let's update Turing instead then. There are about a 100 commits or so since the last release so yes cherry-picking will be a nightmare.

from dynamicppl.jl.

mohamed82008 avatar mohamed82008 commented on June 8, 2024

Does anyone here object to a DPPL release?

from dynamicppl.jl.

mohamed82008 avatar mohamed82008 commented on June 8, 2024

JuliaRegistries/General#13254

from dynamicppl.jl.

phipsgabler avatar phipsgabler commented on June 8, 2024

I guess this is done now? At least if we actually remember to use the dev branch :)

from dynamicppl.jl.

devmotion avatar devmotion commented on June 8, 2024

Yes, and I think lately we actually started using the dev branch, so I'll close this for now.

from dynamicppl.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.