Code Monkey home page Code Monkey logo

Comments (5)

misraved avatar misraved commented on August 16, 2024

Thanks @mthbrown for using Steampipe 👍 . Great to see that you are using the AWS Thrifty mod.

I see that you are using the 0.50.1 version of the AWS plugin, Could you please update it to the latest? We had made certain updates to our cost tables in this release.

We will definitely pick this up and see if we can bring about more optimisations around the cost tables 👍

from steampipe-mod-aws-thrifty.

cbruno10 avatar cbruno10 commented on August 16, 2024

Hey @mthbrown , sorry you ran into some unexpected costs!

In order to better understand your environment to help us improve the query and documentation for these checks, can you please provide some more details around the following:

  • Are the tracked requests all from one account (assuming yes, but wanted to confirm)?
  • How are you running Steampipe + the Thrifty checks, i.e., on a local machine, in a container, in a GitHub action, etc.?
  • How frequently are you running the checks each day or week? Are they running on a schedule, or being manually run?
  • Has caching been disabled anywhere (it's enabled by default)?
  • How many accounts do you have in your AWS organization?
  • Are you running all Thrifty checks, or just particular ones?
  • For the full_month_cost_changes control (which is in the cost_explorer benchmark), approximately how many rows do you get in the check results? For instance, in one of my accounts I just tested against, I get 12 rows (services), which is based on which services I've used recently. This information may help us figure out how many requests are being made to the Cost Explorer API.

If there are any additional details you feel may be helpful, please include them as well.

Thanks!

from steampipe-mod-aws-thrifty.

cbruno10 avatar cbruno10 commented on August 16, 2024

@bigdatasourav Can you please have a look at any controls in this mod that query the AWS Cost Explorer API and track how many API requests each control does? This information will be helpful in determining if our controls and queries are optimized.

from steampipe-mod-aws-thrifty.

bigdatasourav avatar bigdatasourav commented on August 16, 2024

@cbruno10 only the full_month_cost_changes control query the AWS Cost Explorer API in this mod. The API request count is dependent on the number of accounts. Per account, the API will hit once for each time the control runs.

from steampipe-mod-aws-thrifty.

cbruno10 avatar cbruno10 commented on August 16, 2024

Thanks @bigdatasourav for confirming!

@mthbrown Based on our testing, it seems like the control only makes one API call per control run, but if you're still experiencing issues, please let us know and also see the questions in #74 (comment), which can help us debug further. Thanks!

from steampipe-mod-aws-thrifty.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.