Code Monkey home page Code Monkey logo

Comments (4)

seejohnrun avatar seejohnrun commented on July 29, 2024

I'm not going to be changing the signature of the constructor, but in 99e3e8c I've added the ability to set $token and $secret as part of it. Do you have a use case for the array construction, or just uniformity to the JS client?

from tumblr.php.

jbinfo avatar jbinfo commented on July 29, 2024

no no, just for uniformity :)

the $consumerKey and $consumerSecret in the construct method are mandatory for the API ? if so, it will be better to remove the default value of two arguments:

public function __construct($consumerKey, $consumerSecret, $token = null, $secret = null)

from tumblr.php.

seejohnrun avatar seejohnrun commented on July 29, 2024

In practicality only the $consumerKey is required

from tumblr.php.

jbinfo avatar jbinfo commented on July 29, 2024

👍

from tumblr.php.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.