Comments (3)
Thank you!
Rather than deleting the pytorch and torch_geometric dependencies we should specify the correct pip names. Especially the version number can be important.
Similarly for the Python version, which should say something like python_version>=3.8
.
from gemnet_pytorch.
Good point! If one wants to install torch
and torch_geometric
via pip install -r requirements.txt
the CUDA version must be fixed which may not be desired.
For instance, for CUDA 10.2 one could add
torch==1.10
However, for CUDA 11.3 it must be
--extra-index-url https://download.pytorch.org/whl/cu113
torch==1.10
For torch_geometric
it gets more complicated with the CUDA version since you also need the torch
version.
I am not sure whether PEP508 is the correct solution regarding the python version. It more or less makes the dependence of a package depending on the python version but if you want to fix the python version you should require a minimum and maximum in your setup.py
, see python_requires
.
from gemnet_pytorch.
Fixed in 0110dce.
I don't think we need to specify CUDA at all. Imho, the user is responsible for this if they want to use CUDA.
from gemnet_pytorch.
Related Issues (14)
- Coll dataset HOT 2
- Error at line 287 in basis_layers.py HOT 1
- QM9 dataset HOT 1
- A potential bug in data_provider.py HOT 1
- Question about the gradient of positions HOT 1
- Some questions regarding reducing the size of both input and model? HOT 3
- Reproducing Questions HOT 1
- Question about pretrained weights HOT 2
- the dihedral angle difinition HOT 1
- Gradients from analytical differentiation HOT 1
- Question about basis functions used HOT 2
- Question about creating graph HOT 3
- The code that predicts on the test set? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gemnet_pytorch.