Code Monkey home page Code Monkey logo

Comments (3)

gasteigerjo avatar gasteigerjo commented on July 27, 2024

Thank you!

Rather than deleting the pytorch and torch_geometric dependencies we should specify the correct pip names. Especially the version number can be important.

Similarly for the Python version, which should say something like python_version>=3.8.

from gemnet_pytorch.

n-gao avatar n-gao commented on July 27, 2024

Good point! If one wants to install torch and torch_geometric via pip install -r requirements.txt the CUDA version must be fixed which may not be desired.
For instance, for CUDA 10.2 one could add

torch==1.10

However, for CUDA 11.3 it must be

--extra-index-url https://download.pytorch.org/whl/cu113
torch==1.10

For torch_geometric it gets more complicated with the CUDA version since you also need the torch version.

I am not sure whether PEP508 is the correct solution regarding the python version. It more or less makes the dependence of a package depending on the python version but if you want to fix the python version you should require a minimum and maximum in your setup.py, see python_requires.

from gemnet_pytorch.

gasteigerjo avatar gasteigerjo commented on July 27, 2024

Fixed in 0110dce.

I don't think we need to specify CUDA at all. Imho, the user is responsible for this if they want to use CUDA.

from gemnet_pytorch.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.