Code Monkey home page Code Monkey logo

Comments (1)

klippx avatar klippx commented on June 6, 2024

On second thought, if a response ends with 500 that should throw a Response. For graphql we have GraphQLError which takes an originalError, so we could expose a MappersmithError that takes the Response as an argument.

Example, as error handling middleware:

      async response(next) {
        try {
          return await next();
        } catch (response) {
          if (response instanceof Response) {
            throw new GraphQLError(
              originalError: new MappersmithError(response),
              # ...
            );
          }
          throw e;
        }
      },

Where MappersmithError is something as simple as:

export class MappersmithError extends Error {
  public name = 'MappersmithError';
  public response: Response;

  constructor(response: Response) {
    super('Something went wrong in a request');
    this.response = response;
  }
}

We don't want to expose this middleware in mappersmith since we are zero dependency / zero peer dependency.

The thrown object can be an error with stack trace but you have to type assert for that scenario in the middleware.

from mappersmith.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.