XcodeProj Writable conformance does not include WorkspaceSettings about xcodeproj HOT 6 CLOSED

I'm happy to contribute a PR to resolve the issue described above assuming the proposal makes sense!

from xcodeproj.

Hey @dayton-bobbitt I'm working on a PR to integrate the xcuserdata folder and because a *.xcuserdatad folder can also contains schemes I had to rewrite this logic a bit.. also conforming XCSharedData to Writable.

I just stumbled on the WorkspaceSettings not being written and when looking of existing issues I found your issue! Shall I call WorkspaceSettings.write(path:override:) inside of XCSharedData in my PR, or shall I leave it as is so you can fix it and maybe write some tests for it?

from xcodeproj.

Hey @teameh! I wouldn’t mind making the change and adding some additional tests.

Do you want me to make the change in your branch or is your PR almost ready to merge, in which case I can just wait to branch off main until then?

from xcodeproj.

Cool. See main...teameh:XcodeProj:xcuserdata-support for my branch.
PR will follow tonight or tomorrow. PR: #739

from xcodeproj.

Finished updating so that WorkspaceSettings are written when calling XCSharedData's write method. See https://github.com/teameh/XcodeProj/compare/xcuserdata-support...dayton-bobbitt:XcodeProj:write-workspace-settings?expand=1

Planning to open PR against main once #739 is merged.

from xcodeproj.

Cool!

from xcodeproj.