Comments (3)
this is a complex case.
If one has a valid Solid, let's say a cube, and tries to add another face dangling, either touching at a vertex or incident to an edge, then I can't with CGAL (or don't know how) make the difference between these 2 cases, I'll just know it's non-manifold.
But if you check in /data/obj/nonmanifold.obj there's an interesting case.
val3dity nonmanifold.obj -p Solid
--> error 302
val3dity nonmanifold.obj -p CompositeSurface
--> error 303 (because here the surface is valid but the umbrella is not complete...
Thus, some error 303 are reported as 304, but not all :/
I can think I should merge the two errors indeed. I need to sleep on that one, perhaps there's a solution I haven't figured out.
from val3dity.
Hm, just a guess, but would sth work along these lines?
- if 303 or 304 reported
- get the edges that cause the problem
- if any of these edges share >1 (or exactly 2) vertices, then
- report 304
- else report 303
from val3dity.
fixed, 303 is now for both: "NON_MANIFOLD_CASE"
from val3dity.
Related Issues (20)
- Possibility to report OBJ_IDs only HOT 1
- ERROR code source? HOT 3
- 502 - Some more details? HOT 1
- OFF files having duplicate vertices are not handled correctly HOT 1
- Possible false-positive 302 when using gml:OrientableSurface HOT 1
- Error code 601 - Buildingparts_overlap HOT 1
- Invalid OBJ file with VID 0 may cause segfault
- make sure the new report works with GeometryTemplate HOT 1
- add PLY support? HOT 1
- add JSON-FG support?
- fme-gen-UUID's in val3dity report HOT 2
- add CityJSONFeature support?
- IndoorGML Geometry2D HOT 1
- e609 should be e906 HOT 1
- Broken link in docs HOT 1
- problem running Val3dity as library (in WSL) HOT 3
- Repair Report list of features HOT 2
- Val3dity Report Inconsistency
- Val3dity Report error id MultiSolid and CompositeSolid HOT 2
- Discussion HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from val3dity.