Code Monkey home page Code Monkey logo

Comments (3)

hugoledoux avatar hugoledoux commented on July 23, 2024

this is a complex case.

If one has a valid Solid, let's say a cube, and tries to add another face dangling, either touching at a vertex or incident to an edge, then I can't with CGAL (or don't know how) make the difference between these 2 cases, I'll just know it's non-manifold.

But if you check in /data/obj/nonmanifold.obj there's an interesting case.
val3dity nonmanifold.obj -p Solid --> error 302
val3dity nonmanifold.obj -p CompositeSurface --> error 303 (because here the surface is valid but the umbrella is not complete...

Thus, some error 303 are reported as 304, but not all :/

I can think I should merge the two errors indeed. I need to sleep on that one, perhaps there's a solution I haven't figured out.

from val3dity.

balazsdukai avatar balazsdukai commented on July 23, 2024

Hm, just a guess, but would sth work along these lines?

  1. if 303 or 304 reported
    1. get the edges that cause the problem
    2. if any of these edges share >1 (or exactly 2) vertices, then
      1. report 304
    3. else report 303

from val3dity.

hugoledoux avatar hugoledoux commented on July 23, 2024

fixed, 303 is now for both: "NON_MANIFOLD_CASE"

from val3dity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.