Damage Overlay bugged about tttreborn HOT 5 CLOSED

(after my PR)
Damage indicator had minor bug where executing suicide while being dead would display damage indicator. Alternative was that last dmg before death was not displaying properly.

(after recent AliveHud PR / I haven't checked it)
Damage indicator will dissapear after death which will look a bit odd (a least for me)

(Ideal behaviour)
Damage indicator display after death but does not trigger when player is dead. Possible, it would mean that we have to move damage indicator from AliveHUD to GeneralHUD and implement PlayerState.Dying or disable suicide for dead people.

I would close it untill final release since hud functionality might change several times in the meantime.

from tttreborn.

Yeah that should fix the issue, let's keep this GitHub issue for this as it's tangentially related.

from tttreborn.

change to:

float remainingDamageIndicatorTime = Math.Max(_lastDamage / player.MaxHealth, _maxDamageIndicatorDuration);

from tttreborn.

@Krzyska-Filip do you want to throw up a PR for this? Thanks for looking into this.

from tttreborn.

Can this be closed?

from tttreborn.