Comments (6)
17twenty
commented on August 16, 2024
Why can't you just use go get -u github.com/ttacon/libphonenumber?
What would a godeps.json add?
from libphonenumber.
steelbrain
commented on August 16, 2024
@17twenty I did try go get, but this package depends on external dependencies that are not automatically installed by go get. Adding a Godeps file would indicate the consumers which dependencies need to be installed
from libphonenumber.
17twenty
commented on August 16, 2024
I couldn't repeat that issue. The issue with godeps is it links to a
package manager that may or may not be wanted as a dependency
…On 19 Apr 2017 6:52 pm, "Steel Brain" ***@***.***> wrote:
@17twenty <https://github.com/17twenty> I did try go get, but this
package depends on external dependencies that are not automatically
installed by go get. Adding a Godeps file would indicate the consumers
which dependencies need to be installed
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#48 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXJKHT7ZIiiB9OEKIIzEv8h5bm1TB81ks5rxcs8gaJpZM4L9cXr>
.
from libphonenumber.
steelbrain
commented on August 16, 2024
That's not entirely true, when you add Godeps state file, you are not actually tying this package to a package manager at all. It saves current state of dependencies of this package only, it'll only be used if the person downloading uses a package manager (almost all package managers eg. Glide, godep support this file), if they don't go-get will work just as fine as it does now.
from libphonenumber.
ttacon
commented on August 16, 2024
Feel free to open a PR addressing this @steelbrain!
from libphonenumber.
ttacon
commented on August 16, 2024
Hi @steelbrain, this project is now using dep - let me know if that solves your issue!
from libphonenumber.
Related Issues (20)
- 839 Area code is not shown to be valid HOT 1
- Update library to latest protobuf version
- Not accepting Mexican phone numbers: 5215563189961
- Provide a support for Africell telecom operator in Angola
- Update metadata for support Pakistan 326 codes
- Parse() not throwing error when expected
- PhoneNumberType of London UK Numbers show as UNKNOWN
- Jamaican numbers with 407 prefix return invalid
- HK 4 prefix phone number invalidate
- Rules for validating Vietnam phone numbers have changed HOT 5
- Can we have a change log? HOT 1
- Some valid phone numbers returning false when IsPossibleNumber is called HOT 5
- Get full country name using codes
- How do I check if a number is a fixed line number or not?
- go.mod required for projects which are using Go >= 1.12
- invalid number HOT 3
- Metadata is out of date - new Oman phone numbers not working in this library, but work on Google demo HOT 1
- Not accepting UK as a country
- Implement Telephone_numbers_in_Ivory_Coast
- The new released cell phone number "195***" in China mainland is not supported HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libphonenumber.