Race Condition about vue-plugin-load-script HOT 4 CLOSED

Ive created this PR #18

from vue-plugin-load-script.

I don't believe a race condition exists there. That line exists to prevent duplicate <script> elements for the same source.

Loading does not begin until the <script> element is injected into the DOM. The attribute async has no effect on this behavior.

With that said, I do see a potential for improvement in the error/abort event handlers by removing the <script> element before rejecting the Promise, so failures don't prevent future successes.

from vue-plugin-load-script.

Here's an example:
https://codesandbox.io/s/vue-template-mjdoz?fontsize=14

If loadScript is called multiple times with the same url, the subsequent calls will find the DOM element and immediately resolve (even though the script may not have actually loaded yet).

from vue-plugin-load-script.

Thank you for the example, I hadn't anticipated that usage.

I have a solution in mind that involves tracking script resolvers manually, since HTMLScriptElement is fairly dumb in regards to its current status. It'll take me a few days to get around to it though.

from vue-plugin-load-script.