When specifying filter option, get error in embedFonts about dom-to-image HOT 6 CLOSED

Looks like you're filtering out the node you want to render. Make sure your filter matches that node.

from dom-to-image.

It doesn't matter what I'm actually trying to filter out - returning false from filter in any case results in node being undefined later in Promise chain. Maybe I misunderstand how the library is designed - but what I'm trying to do is give it a container with mixed dom objects in it, and filter function would return true or false for those I want included in resulting svg/foreignobject sandwich, and skip all the others.

I "fixed" it by changing this line:
From:
if (filter && !filter(node)) return Promise.resolve();
To:
if (filter && !filter(node)) return Promise.resolve(document.createElement( 'b' ));

Now there's no exception, and it ends up rendering empty/invisible <b/> instead. But it seems to be a deeper problem here - promise.resolve requires node to be defined later.

from dom-to-image.

Take a look at this test to see how filter should be used. When calling toSvg, you should provide the node you want to render. If your filter does not return true for the node you've provided as first argument, then you'll get this error. Perhaps this situation should be handled better. But if you give right arguments (and make sure that root node passes the filter), your problem should be fixed

from dom-to-image.

Now it makes sense! My filter should've included the container node as well as the things I'm filtering in / out.

Thank you for clearing this up.

from dom-to-image.

welcome :)

from dom-to-image.

FYI, starting from 2.1.0 this issue is handled better, the filter is no longer applied to the root node.

from dom-to-image.