Image background colour about roon HOT 7 CLOSED

Transparent I'd say - feel free to PR!

from roon.

Drew did this on purpose. There was a white loading gif on top of the grey that was there while loading. Noticed the gif didn't get ported over

Sam

On Wed, Dec 10, 2014 at 7:44 AM, JohnONolan [email protected]
wrote:

Transparent I'd say - feel free to PR!

Reply to this email directly or view it on GitHub:
#4 (comment)

from roon.

@soffes ok, probably better to port it over then. What happens though when the image is transparent? Now you're left with an awful looking image.

from roon.

It's only while loading

Sam

On Wed, Dec 10, 2014 at 9:21 AM, James Brooks [email protected]
wrote:

@soffes ok, probably better to port it over then. What happens though when the image is transparent? Now you're left with an awful looking image.

Reply to this email directly or view it on GitHub:
#4 (comment)

from roon.

So some JavaScript is ensuring that once the load is done, the background is changed?

from roon.

Yes.

Sam

On Wed, Dec 10, 2014 at 9:22 AM, James Brooks [email protected]
wrote:

So some JavaScript is ensuring that once the load is done, the background is changed?

Reply to this email directly or view it on GitHub:
#4 (comment)

from roon.

Like Sam says, the JavaScript that handled this was removed when I ported the theme over.

I think the best course of action here (if you still looking to contribute @jbrooksuk ?) is to just remove any code related to the loading of images.

from roon.