Comments (12)
With this I'm currently implementing the iCheck library but do we need it to be global? or just Settings page?
from ghost.
Is this issue complete, or are we keeping it open until everything is finalised?
from ghost.
Need a report on a few things:
- What's the weight of the library?
- Is it easy to work with?
- What areas have we implemented it in so far?
- Are we calling it on every page, or just in certain areas?
- Did you research/find any viable alternatives?
- Is the library being actively maintained?
from ghost.
What's the weight of the library?
11kb
Is it easy to work with?
Very
What areas have we implemented it in so far?
Just the settings page checkboxes
Are we calling it on every page, or just in certain areas?
I'm currently only calling it in the settings page, but can put it globally very easily.
Did you research/find any viable alternatives?
Nope but can do if you like.
Is the library being actively maintained?
Yup, last commit 4 days ago. https://github.com/damirfoy/iCheck
from ghost.
@ErisDS any objections? I don't like 11kb size, but tbh it does add a level of polish that's very desirable and generally uncommon which I think is fairly important. Maybe trial it for now and kill it if it gets in the way?
from ghost.
I agree, it appears to be variable based on if retina / non-retina graphics are used.
I've got no problem trialing it.
from ghost.
As a developer, and not a designer, I believe that all of these sorts of things are tosh and that native checkboxes are best.
However, given that I will never win that argument, I don't see a problem with this particular library. My issue will come if you then want to use another separate library for selects or some other field.
from ghost.
Cool - let's test it and see how it goes.
from ghost.
Can this be closed now?
from ghost.
@matthojo where have you implemented this that I can see it in action?
from ghost.
settings page as the checkboxes.
from ghost.
The plugin itself looks good - the implementation is a mess. We absolute don't want to use any 3rd party CSS files. We should choose a look and implement our own css properly for this.
I would suggest something similar to the "square" skin
But using Ghost blue, smaller boxes, and without using any images.
from ghost.
Related Issues (20)
- Integrations - FirstPromoter always showing as "active" HOT 2
- Admin API - Create Paid Members support HOT 1
- Node Version Requirement Not Declared Fine Enough HOT 4
- Wrong DNS records shown HOT 1
- Error updating to Ghost 5.80 from 5.23, blog down, please help HOT 1
- Comments broken in latest release HOT 5
- Internal tags not all displayed in admin panel
- Korean Romanization is Wrong HOT 3
- Ghost cannot connect to Mysql AWS RDS instance with latest CA from AWS HOT 2
- Handlebars special partial "@partial-block" gets reported as unknown global HOT 1
- Vulnerability Report: Regular Expression Denial of Service (ReDoS) in moment.js HOT 1
- Plain text view HOT 3
- Installation on Windows Fails with "A SystemError occurred." (nodejs version mismatch) HOT 1
- Newlines not correctly handled in product card titles
- Support Bluesky oEmbed auto-discovery HOT 4
- Editor tooltip for text styling is not visible when using android mobile
- Outdated version of string-width is causing the Docker image entrypoint loading to fail. HOT 2
- Site version in API not showing patch HOT 2
- glibc-vulnerability cve-2024-2961 [BUG] HOT 2
- Visitors on iOS prompted to download empty "auth-frame" file HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ghost.