Code Monkey home page Code Monkey logo

Comments (8)

gclawes avatar gclawes commented on May 28, 2024

The following command should work to build the latest tag manually once this has been merged:

$ git checkout v2.4
$ git checkout master -- Dockerfile
$ docker build -t troglobit/mcjoin:2.4 .
$ docker push troglobit/mcjoin:2.4

from mcjoin.

troglobit avatar troglobit commented on May 28, 2024

Thanks!

Same question as with the pimd docker image, curious why Debian instead of Alpine? In particular for mcjoin which is a tiny application to carry the massive overhead of Debian.

from mcjoin.

gclawes avatar gclawes commented on May 28, 2024

No particular reason, I can submit a PR to switch it in both projects.

from mcjoin.

troglobit avatar troglobit commented on May 28, 2024

That would be really great, thanks! Maybe uninstall autotools as well after autogen.sh ...

You can close these issues by putting "Fix #NUM: GIT message" in your commit. When I merge the PR GitHub will automatically close the issue.

from mcjoin.

gclawes avatar gclawes commented on May 28, 2024

It's a multistage build, so it's a fresh image after the second FROM, only thing that gets carried over is the binary, no need to uninstall.

from mcjoin.

gclawes avatar gclawes commented on May 28, 2024

Once this is built, can you publish it to dockerhub?

from mcjoin.

troglobit avatar troglobit commented on May 28, 2024

Aha, cool good to know! :)

Sure thing, I'll merge, build, and push both of them to dockerhub after work tonight 👍

from mcjoin.

troglobit avatar troglobit commented on May 28, 2024

Done! I had to modify the Dockerfile slightly, but as a side effect it's now stand-alone

from mcjoin.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.