version-file extension not supported even if it's YML inside about conventional-changelog-action HOT 5 CLOSED

Hi @gpiffaretti, that would be a great addition! When a version-file-type is defined we can use that one and if not determine it ourselfs.

Would you like to create a PR?

from conventional-changelog-action.

Created this pull request :)
#61

from conventional-changelog-action.

Tried it in my own fork and it's working. I had to do another addition to make it work with Unity:

fileContent.replace(
          `${versionName}: '${oldVersion}'`,
          `${versionName}: '${this.newVersion}'`,
        )

That part won't work because Unity doesn't use the ' character for the values in the YML file.
I had to change the replace logic but haven't added an option to choose if using the ' or not. I also don't wanna add too much complexity with too many parameters and stuff. What do you think?

Maybe a regex for the replace method? Not familiar with the JS replace method and don't have time right now, but might take a look in the future.

from conventional-changelog-action.

Maybe a simple check like

const quoteType = fileContent.includes(`'${oldVersion}'`) ? '\'' : '"'

?

from conventional-changelog-action.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from conventional-changelog-action.