Comments (6)
Hi @jathu!
Thanks for taking the time to comment on this and raise an issue. I'm glad you find the theme useful. I use it myself every day (the Serene version just like you).
I did notice that the icons are a bit blurry, but couldn't figure out why. I think it may be how Sketch is exporting them, so I will have a look at that.
Regarding the tabs, I wanted to clarify what you meant. At the moment, Serene has a couple of different states for the tabs:
- File not active with no unsaved changes.
- File not active with unsaved changes (dirty).
- File active with no unsaved changes.
- File active and dirty.
Then the hover states for all of these.
When the file is active, it has the reddish background and the font color is same color as the page background. When it is not active, it has the same background as the page and the font color is a brownish color.
Are you proposing that we get rid of the reddish background altogether? This would make the active and non-active files exactly the same and you would have no idea what file you are editing.
What am I missing? :)
Thanks again!
from edge-theme-sublime-text-3.
Yes, I think the red background is a bit much (too much contrast and too bright). I think we should keep the active tab the same color as the background and indicate the active tab by a bottom red border. Inactive tabs can have font with reduce opacity. Similar to how this theme does it: ayu.
Also for the icons you can use feather icons. It's a great open source icon set.
Tell me what you think.
from edge-theme-sublime-text-3.
Thanks for the input! I'm a bigger fan of the full background than the line underneath, but I think I can integrate both via a setting.
I'll see what I can do and let you know!
Cheers,
Bogdan
from edge-theme-sublime-text-3.
Hey @jathu, I've toned down the color for the active tab, and at the same time I've also added the option to configure the way tabs are displayed.
If you set your ST option like this:
edge_use_tab_backgrounds: false
then you will get the little border at the bottom of the active tabs.
This option is available since v1.1.0 of the theme. At this moment, 1.0.4 is still the current one in Package Control, so have a little patience ;)
Also fixed the blurry icons btw. :)
Let me know what you think.
Cheers,
Bogdan
from edge-theme-sublime-text-3.
Awesome, thank you!
from edge-theme-sublime-text-3.
You're welcome! Thanks for the support!
from edge-theme-sublime-text-3.
Related Issues (3)
- For another editor HOT 1
- Side scrollbar glitch HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from edge-theme-sublime-text-3.