Bandwidth Accounting/Tokens/Trust cleanup about tribler HOT 9 CLOSED

I'm not sure if any of these strings would be visible in the UI.

The first file in the first link above is visible in the UI under Settings > Anonymity

from tribler.

For example 1st link 2nd file "You can build trust by contributing bandwidth to the Tribler network."

Should be removed.

While not all strings show up in the UI, having dead code makes it hard to find the strings that do show up in the UI (as was demonstrated with "Settings > Anonymity").

from tribler.

@Dmole, thank you for reporting.

I'm not certain it can be classified as a bug since there's nothing dangerous or unintended in the application's behavior. It seems more like a candidate for refactoring. Also, I'm not sure if any of these strings would be visible in the UI.

Related:

• #7336

from tribler.

It looks like the links in the OP still return some items that should be cleaned up.

from tribler.

@Dmole, could you please provide the items that, in your opinion, should be removed? Not all items from the original post may need to be removed.

from tribler.

That's progress but

For example 1st link 2nd file
"You can build trust by contributing bandwidth to the Tribler network."
Should be removed.

and other issues linked in the OP persist.

from tribler.

@Dmole, please post here all the places you propose to remove, and we can discuss them in detail.

from tribler.

Looks like the string quoted in my last comment may have just been in a github cache.

Among the other files linked in the OP,
Please remove these files:

1. draft-pouwelse-trustchain-00 never handled negative trust in a tamper proof way (,the channels are cert based, not really "accounting") and is no longer relevant to Tribler:

• https://github.com/Tribler/tribler/blob/main/doc/draft-pouwelse-trustchain-00.txt
• https://github.com/Tribler/tribler/blob/main/doc/draft-pouwelse-trustchain-00.xml

2. "Start a crawler in the bandwidth accounting community" there is no longer any bandwidth accounting right?

• https://github.com/Tribler/tribler/blob/main/scripts/crawler/run_crawler.py

Among the trust search results :

1. There is no longer a "Trust Graph"

• https://github.com/Tribler/tribler/blob/main/src/tribler/gui/i18n/pt_BR.ts#L2411

2. "trustview" is no longer an endpint right?

• https://github.com/Tribler/tribler/edit/main/doc/restapi/introduction.rst

from tribler.

draft-pouwelse-trustchain-00 never handled negative trust in a tamper proof way (,the channels are cert based, not really "accounting") and is no longer relevant to Tribler:

As far as I understand, this document is still in use. @synctext, could you confirm?

"Start a crawler in the bandwidth accounting community" there is no longer any bandwidth accounting right?
https://github.com/Tribler/tribler/blob/main/scripts/crawler/run_crawler.py

This crawler is left as an example of how to write a crawler for Tribler. See the description of the file for more details.

There is no longer a "Trust Graph"
https://github.com/Tribler/tribler/blob/main/src/tribler/gui/i18n/pt_BR.ts#L2411

Confirmed. I'll remove it.

"trustview" is no longer an endpint right?
https://github.com/Tribler/tribler/edit/main/doc/restapi/introduction.rst

Confirmed. I'll remove it.

from tribler.