Comments (2)
Hi @olkeoguz!
Please use kebab-case
for attribute names (like current-page
instead of currentPage
).
"Rules" sections is for listing the behavioural rules (if we have any) about this component. If we don't have any rules, you can omit that part.
I assume bl-change
event will contain the new page number in the event data. If so please mention it. And maybe we can consider to include previous page number in that event too. In some cases it would be helpful to track user interaction.
And what about labels for "results per page" select and "jumper" input? Do we consider to set them inside the component and not give a chance to customize them?
from baklava.
Hi @muratcorlu ,
-
Excellent idea to the add previous page in the event. Thank you.
-
About the last suggestion you made, I thought, we were considering to add the multi-language option to Baklava and these areas were supposed to be static. But it makes sence to allow users for the labels. If that's the final decision, i can add it.
-
I will update the rules part after we decide the result-per-page options.
from baklava.
Related Issues (20)
- [BUG]: The wrong event is triggered when the pagination select is changed HOT 2
- [BUG]: Handle destroy of dialog component
- [BUG]: Encountering the 'browserContext.newPage: Target closed' error when using web-test-runner after macOS 14, specifically failing on WebKit HOT 2
- [Feature Request]: Implement icon prop and slot on Textarea component HOT 1
- [BUG]: The Baklava logo does not appear clearly in the dark theme. HOT 6
- [BUG]: When we write our tests in our react and vit project, we get errors on the jest side.
- Optimize and Benchmark Baklava Design System Performance
- [BUG]: bl-select disabled item count HOT 2
- [BUG]: disabled bl-select can be updated HOT 1
- [BUG]: searchable select component default empty list HOT 9
- [Component]: Calendar component HOT 3
- [BUG]: Dialog does not trap focus HOT 2
- [BUG]: bl-select is not aware of attribute changes of bl-select-option HOT 1
- Tree Select Feature for Select Component
- [BUG]: Tooltip trigger issue
- [BUG]: Baklava select input popover close event trigger problem HOT 2
- trendyol.design Website HOT 1
- [BUG]: border-top is not coming correctly in BlInput label animation HOT 3
- Enhancing SSR Compatibility HOT 1
- npm install @trendyol/baklava
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from baklava.