Code Monkey home page Code Monkey logo

Comments (2)

muratcorlu avatar muratcorlu commented on May 22, 2024 1

Hi @olkeoguz!

Please use kebab-case for attribute names (like current-page instead of currentPage).

"Rules" sections is for listing the behavioural rules (if we have any) about this component. If we don't have any rules, you can omit that part.

I assume bl-change event will contain the new page number in the event data. If so please mention it. And maybe we can consider to include previous page number in that event too. In some cases it would be helpful to track user interaction.

And what about labels for "results per page" select and "jumper" input? Do we consider to set them inside the component and not give a chance to customize them?

from baklava.

olkeoguz avatar olkeoguz commented on May 22, 2024

Hi @muratcorlu ,

  • Excellent idea to the add previous page in the event. Thank you.

  • About the last suggestion you made, I thought, we were considering to add the multi-language option to Baklava and these areas were supposed to be static. But it makes sence to allow users for the labels. If that's the final decision, i can add it.

  • I will update the rules part after we decide the result-per-page options.

from baklava.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.