Comments (4)
I have studied some other style guides for this question:
- https://gist.github.com/fredbenenson/7bb92718e19138c20591
- https://github.com/meadmaker/sql-style-guide
- http://leshazlewood.com/software-engineering/sql-style-guide/
And they are all just so far behind the times. They do not provide any useful commentary on the subject.
So just from the looks of it, I will say your choice,
...
LEFT JOIN (pmt_orders JOIN wp_users
ON wp_users.ID = pmt_orders.user_id)
as well as
...
LEFT JOIN ( pmt_orders
JOIN wp_users
ON wp_users.ID = pmt_orders.user_id)
seem categorically better than the others. The "river" rule is strong and should not be violated. Otherwise, the one-liner is a non-answer, since any indentable thing could be a one-line in the right circumstance.
End result, I agree with your choice.
from sqlstyle.guide.
I've given this a little thought, but not sure I've come to a conclusion yet. There are quite a few options, of which, these are just a few. I am not sure I have a strong opinion either way on these.
SELECT pmt_courses.course_name, pmt_tokens.token, pmt_orders.order_id, wp_users.user_email
FROM wp_pmt_order_token
JOIN pmt_courses
ON pmt_courses.course_id = pmt_tokens.course_id
LEFT JOIN (pmt_orders
JOIN wp_users
ON wp_users.ID = pmt_orders.user_id)
ON pmt_orders.order_token = pmt_tokens.token
WHERE wp_pmt_order_token.fk_order_id = 28997
SELECT pmt_courses.course_name, pmt_tokens.token, pmt_orders.order_id, wp_users.user_email
FROM wp_pmt_order_token
JOIN pmt_courses
ON pmt_courses.course_id = pmt_tokens.course_id
LEFT JOIN (pmt_orders JOIN wp_users ON wp_users.ID = pmt_orders.user_id)
ON pmt_orders.order_token = pmt_tokens.token
WHERE wp_pmt_order_token.fk_order_id = 28997
SELECT pmt_courses.course_name, pmt_tokens.token, pmt_orders.order_id, wp_users.user_email
FROM wp_pmt_order_token
JOIN pmt_courses
ON pmt_courses.course_id = pmt_tokens.course_id
LEFT JOIN (pmt_orders JOIN wp_users
ON wp_users.ID = pmt_orders.user_id)
ON pmt_orders.order_token = pmt_tokens.token
WHERE wp_pmt_order_token.fk_order_id = 28997
SELECT pmt_courses.course_name, pmt_tokens.token, pmt_orders.order_id, wp_users.user_email
FROM wp_pmt_order_token
JOIN pmt_courses
ON pmt_courses.course_id = pmt_tokens.course_id
LEFT JOIN ( pmt_orders
JOIN wp_users
ON wp_users.ID = pmt_orders.user_id)
ON pmt_orders.order_token = pmt_tokens.token
WHERE wp_pmt_order_token.fk_order_id = 28997
SELECT pmt_courses.course_name, pmt_tokens.token, pmt_orders.order_id, wp_users.user_email
FROM wp_pmt_order_token
JOIN pmt_courses
ON pmt_courses.course_id = pmt_tokens.course_id
LEFT JOIN (
pmt_orders
JOIN wp_users
ON wp_users.ID = pmt_orders.user_id
)
ON pmt_orders.order_token = pmt_tokens.token
WHERE wp_pmt_order_token.fk_order_id = 28997
SELECT pmt_courses.course_name, pmt_tokens.token, pmt_orders.order_id, wp_users.user_email
FROM wp_pmt_order_token
JOIN pmt_courses
ON pmt_courses.course_id = pmt_tokens.course_id
LEFT JOIN (pmt_orders
JOIN wp_users
ON wp_users.ID = pmt_orders.user_id)
ON pmt_orders.order_token = pmt_tokens.token
WHERE wp_pmt_order_token.fk_order_id = 28997
from sqlstyle.guide.
If I were to pick one it would probably be:
SELECT pmt_courses.course_name, pmt_tokens.token, pmt_orders.order_id, wp_users.user_email
FROM wp_pmt_order_token
JOIN pmt_courses
ON pmt_courses.course_id = pmt_tokens.course_id
LEFT JOIN (pmt_orders JOIN wp_users
ON wp_users.ID = pmt_orders.user_id)
ON pmt_orders.order_token = pmt_tokens.token
WHERE wp_pmt_order_token.fk_order_id = 28997
Have you had any further thoughts on this @fulldecent ?
from sqlstyle.guide.
I agree with
LEFT JOIN (pmt_orders JOIN wp_users
ON wp_users.ID = pmt_orders.user_id)
as well because of its adherence to the river rule, which I've found to be very helpful for readability. Subjectively, I find it to be the easiest of all to read.
from sqlstyle.guide.
Related Issues (20)
- clicking link doesn't update fragment in URL HOT 3
- add link for OOP design vs. SQL HOT 3
- Grammer error in German translation HOT 1
- Audit columns HOT 1
- This guide is fantastic HOT 1
- Italian translation HOT 6
- CHECK pens_in_drawer violates "preferred formalisms" re. BETWEEN HOT 1
- Order of foreign key? HOT 1
- Backticks (backquotes?) in style. HOT 2
- Naming convention for boolean columns HOT 3
- Some additional uniform-suffixes for consideration HOT 1
- JOIN in Aliasing or correlations example not indented right HOT 1
- Possible indent typo on sqlstyle.guide website HOT 1
- ISO Date/Time Format HOT 2
- How are you aligning the first word on each line? HOT 2
- Ukrainian translation suggestion
- [just suggestion] from gitlab style (indentation 2 spaces) HOT 1
- Reconsider JOIN Style
- Mine
- https://sqlstyle.guide gives cloudflare's ssl exception HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sqlstyle.guide.