Comments (2)
Thanks for your thoughts!
Haven't read through it fully but some coments on this.
At least I wonder if that has been considered ?
I haven't thought about this yet since I had no issue with the time it needs until now. But for larger countries there might be a significant impact. Adding your PR #207 ith printing out the taken time should be done before to be able to measure the performance gains.
I also wonder if it is really necessary to generate two different files with the "tags-filter" or if this could be done in one command. I have just tested the performance for doing the osmium extract on one merged file versus two separate files.
I had the same question, see #109 but in the end relied on @Ebe66 because he somehow is the creator of the base structure in generating the tiles.
So I have actually not generated the map and verified that the map ends up being correct. I wanted input if you think this approach is useful, before spending more time on it. And looking for input how to verify that the generated tiles are identical.
I have some unittests to validate some parts of the generated files with static input files and against static generated files, see: https://github.com/treee111/wahooMapsCreator/blob/develop/tests/test_generated_files.py.
Due to recent changes the unittests are not green. In addition what I wrote at the beginning, this should also be corrected before implementing your new stuff.
As I have limited time at the moment and - as written - there might be some stuff to do I would appreciate some help on this.
from wahoomapscreator.
Hi, this sounded like a good idea so I tried this with my version of the wahoomapscreator, on windows with osmconvert and osmfilter today with Germany including all sub-regions.
It is faster, but just barely unfortunately. My old version with the non merged files took exactly 1 hour, the version that merges the filtered files before splitting took 57 minutes.
The need for two filter stages is described in the issue Treee111 refers to. Is it absolutely needed? No, but it keeps the generated map sizes a lot smaller.
There is an indication in your test files, I assume you changed the filters (or there is something else going on with treee111's version on linux c.q. osmium) but your filtered_names.o5m.pbf file is significantly larger than your filtered.o5m.pbf file.
The names file should be very much smaller than the no names file. I guess it contains all streetnames for example which would end up in the map file while the Wahoo device does not use them at all. If you compared your map files with mine on wahoomaps.higli.de, you will likely see my maps are smaller.
from wahoomapscreator.
Related Issues (20)
- Consider switching to pyhgtmap (fork) for contour lines HOT 2
- Routing tiles HOT 3
- Areas with landuse=farmland cover some tracks with vtm_theme_poi HOT 9
- Output folder name is too long HOT 8
- Mapwriter plugin missing in the current osmosis package HOT 9
- Add LICENSE file to the repo
- A collection of performance improvements HOT 1
- Add unittests with a country file outside of the repo
- Support of veloviever tile oververlay HOT 1
- Question about adding POIs to original wahoo map HOT 1
- Add information create routing automatically HOT 1
- Question: Can't Find POI Files HOT 4
- Error in osmosis when running wahoomc HOT 2
- Tiles were not generated but wahoomc logs said they were HOT 2
- Cruiser not working with default VTM theme HOT 7
- Footpath with Bike Access
- Map Source Data HOT 5
- Byways vs Tracks HOT 23
- POI not showing HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wahoomapscreator.