Code Monkey home page Code Monkey logo

Comments (7)

rewinfrey avatar rewinfrey commented on June 6, 2024 1

@banacorn thanks for filing this issue. @maxbrunsfeld and I did some work on the external scanner and uncovered a condition that could result in non-termination. Those changes have been pushed to master, and should prevent your Atom instance from freezing. Do you mind checking out the latest master and verifying if the infinite looping is still occurring for you?

from tree-sitter-haskell.

rewinfrey avatar rewinfrey commented on June 6, 2024 1

@banacorn This is definitely on our radar, but as I'm still working on adding more Haskell language support for its multitude of language extensions, I've not prioritized getting this working in Atom yet. Thank you for your patience.

from tree-sitter-haskell.

rewinfrey avatar rewinfrey commented on June 6, 2024 1

@banacorn it's my understanding Atom currently isn't configured to use the get_column API that tree-sitter-haskell's external scanner depends on for parsing layout rules. This won't affect other external scanners because as of right now, tree-sitter-haskell is the only grammar that requires the get_column API (and is the motivation for why it was added to tree-sitter). @maxbrunsfeld please correct me if I'm misunderstanding!

@banacorn, unfortunately there are other problems with the external scanner not parsing some layout cases correctly. At this time I would say tree-sitter-haskell is still not stable enough to depend on for other packages and is still a WIP.

from tree-sitter-haskell.

banacorn avatar banacorn commented on June 6, 2024

Thank you for looking into this!
I've tried out the latest scanner but it still freezes after a few keystrokes 😢

from tree-sitter-haskell.

banacorn avatar banacorn commented on June 6, 2024

I want to fix this, but I can't locate the source of the problem.

Could it be the scanner? If so, then perhaps instead of adding new stuff, should we fix the non-termination first?
Could it be tree-sitter or Atom? If so, then perhaps other packages that also rely on external scanners could face this problem, too?

from tree-sitter-haskell.

clojj avatar clojj commented on June 6, 2024

@banacorn, unfortunately there are other problems with the external scanner not parsing some layout cases correctly. At this time I would say tree-sitter-haskell is still not stable enough to depend on for other packages and is still a WIP.

@rewinfrey
Apart from the IntelliJ's Haskell-plugin (the grammar of which is kind of a 'monster' I can imagine) and maybe some internal Yi-Editor parsing-code, tree-sitter-haskell is to my knowledge the only available incremental Haskell parser available. It would be a very sad situation, if this has to stop with unresolvable issues
I am curious about the status of tree-sitter-haskell... are these issues resolvable in your opinion ?

from tree-sitter-haskell.

tek avatar tek commented on June 6, 2024

this applied to the version from before the rewrite, cannot reproduce it now.

from tree-sitter-haskell.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.