get an ast with identifier values about py-tree-sitter HOT 10 CLOSED

I'll get through it and let you know.

(Sadly, I see that proper abd efficient implementation will require more time i can spare. Sorry.)

from py-tree-sitter.

@maxbrunsfeld

Very good. My problem has been solved. Thank you very much.

I think you can add an attribute to identifier node to get the text of the node. Because identifier node text is a user-defined value, getting this value may be more useful.
I just put forward my opinion. You can think about it again.

from py-tree-sitter.

any update on this matter, can we use the .text to get the identifier value now?

from py-tree-sitter.

Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details.

from py-tree-sitter.

Currently, the way to get the text for an ast node is to use the Node.start_byte and node.end_byte properties:

tree = parser.parse(source_code_bytes)

# ...

text = source_code_bytes[node.start_byte:node.end_byte]

Does that help? I think it'd be possible to add a more convenient API also, but I'm not sure what it should be.

from py-tree-sitter.

Would it be possible to support a .text property as is done in the JavaScript bindings?

from py-tree-sitter.

Regarding .text for nodes, roughly, I think the way it is done in node-tree-sitter is something like:

• When a SyntaxNode is created, it is passed a tree in its constructor: https://github.com/tree-sitter/node-tree-sitter/blob/209e734e8df0bc0b79ef0af222843a92ce9c5c8c/index.js#L47-L50

• If the node's .text() is used, the associated tree's .getText() is called: https://github.com/tree-sitter/node-tree-sitter/blob/209e734e8df0bc0b79ef0af222843a92ce9c5c8c/index.js#L76-L78

• That .getText() was arranged for when parse was called to create the tree that the node is a part of -- if it was a string that was parsed, this is retained as part of the tree: : https://github.com/tree-sitter/node-tree-sitter/blob/209e734e8df0bc0b79ef0af222843a92ce9c5c8c/index.js#L271-L293

That's not the whole story it seems, but at any rate, it gives some idea of possibly what could be done in the case of py-tree-sitter.

from py-tree-sitter.

Is there any plan about it? I can handle the implementation.

from py-tree-sitter.

I was working on an implementation in #37, but am not attached to it.

I don't know if anyone else is working on this functionality.

If you do end up going ahead with something and haven't looked at the discussion in #37, I think it might be good to take a look.

from py-tree-sitter.

node.text was recently merged, it should work on HEAD

from py-tree-sitter.