Code Monkey home page Code Monkey logo

Comments (5)

zoloft avatar zoloft commented on August 27, 2024

Yes that was an addition that i made to run the makefile on my system (fedora) where by default backslash escapes interpretation is disabled. It can be safely removed.

from jsencrypt.

travist avatar travist commented on August 27, 2024

I would like to move this library to use Grunt, so the makefile should probably go away in the future.

from jsencrypt.

 avatar commented on August 27, 2024

Hey,

imho, this newline is not needed there. A fix would be to add a newline at the end of file src/jsencrpyt.js and to make the line in the Makefile simply @echo "exports.JSEncrypt = JSEncrypt;" >> bin/jsencrypt.js. Result looks like before, and hey, it gets minimized in the end ;)
It would simplify building that nice lib as well.

index 4b409f1..f4436ac 100644
--- a/makefile
+++ b/makefile
@@ -33,7 +33,7 @@ js: ${files}
        @echo "var JSEncryptExports = {};" > bin/jsencrypt.js
        @echo "(function(exports) {" >> bin/jsencrypt.js
        @cat $^ >> bin/jsencrypt.js
-       @echo -e "\nexports.JSEncrypt = JSEncrypt;" >> bin/jsencrypt.js
+       @echo "exports.JSEncrypt = JSEncrypt;" >> bin/jsencrypt.js
        @echo "})(JSEncryptExports);" >> bin/jsencrypt.js
        @echo "var JSEncrypt = JSEncryptExports.JSEncrypt;" >> bin/jsencrypt.js
        @echo "Generating compressed jsencrypt.min.js file"
diff --git a/src/jsencrypt.js b/src/jsencrypt.js
index 14ff1de..a98f59c 100644
--- a/src/jsencrypt.js
+++ b/src/jsencrypt.js
@@ -474,4 +474,5 @@ JSEncrypt.prototype.getPublicKey = function() {
 JSEncrypt.prototype.getPublicKeyB64 = function() {
     // Return the private representation of this key.
     return this.getKey().getPublicBaseKeyB64();
-};
\ No newline at end of file
+};
+

Regards
Joachim

from jsencrypt.

travist avatar travist commented on August 27, 2024

If you put in a pull request for ^, I will gladly approve and merge. Thanks.

from jsencrypt.

travist avatar travist commented on August 27, 2024

This is now fixed. Thanks @shing19m !

from jsencrypt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.