Code Monkey home page Code Monkey logo

Comments (7)

cbizon avatar cbizon commented on July 29, 2024

@YaphetKG is it possible to customize the example queries per-plater instance? All of the ones on the automat site use this same disease to chemical entity query, even though it's not really a valid query for most of them.

Also, is it the case that the prefixes in meta_knowledge_graph are built from the data? Or does plater make assumptions about what the data ought to look like?

from plater.

YaphetKG avatar YaphetKG commented on July 29, 2024

Hi @cbizon , @karafecho
For the example query i think we can replace the example on deployment by mounting a custom json inplace of the default file. That way we can customize each instance with no code change to the repo.

As for prefixes , meta_kg is built from the data (

def get_curie_prefix_by_node_type(self, node_type):
) this function is responsible for doing so. We don't do any filtering and the raw prefixes on the nodes.

I checked the ICEES neo4j for nodes that have that curie listed in their id as well as equivalent ids

match (c) where any (x in c.equivalent_identifiers where x starts with 'RXNORMCUI') return c limit 1

but there seems to be no result. Could be the data is something different(?)

from plater.

karafecho avatar karafecho commented on July 29, 2024

Thanks for investigating, Yaphet.

Please let me know if you need anything from me to address the example queries.

WRT the meta KG prefixes, I'm confused. I had initially brought the issue to Max's attention, but he thought it was a Plater issue. @maximusunc, any insights?

from plater.

karafecho avatar karafecho commented on July 29, 2024

@YaphetKG @cbizon : So, Max reminded me that the current issue reflects a decision I made a while back. In short, Max, Hong, and I have been refactoring ICEES into two separate services: ICEES (fully featured, dynamic, non-TRAPI) and ICEES KG (limited in features, static, TRAPI). As part of that effort, we've been working to more fully automate and improve the various mapping steps, which had been introducing a lot of noise and incorrect mappings. The new process begins with a file that I manually created and that is leveraged for various downstream mapping and enumeration steps. The mapping of ICEES feature variables to Biolink prefixes/CURIES is based on search_term entries and limit parameters that I provided and that are used to programmatically call Name Resolver and retrieve Biolink CURIES for each variable. I tested the approach extensively and was aware of the limitations but felt it was best to harmonize with Translator than to harmonize with FHIR. However, when I looked at the meta KG, I had second thoughts.

I'm thinking that we should stick with the current approach, recognizing the limitations but accepting them. Note that there are related GitHub tickets that should eventually address these issues.

RxNorm: Biolink resolved RxNorm issue, moved issue to Node Normalizer, TranslatorSRI/NodeNormalization#127

ICD: open Biolink ticket, biolink/biolink-model#933

LOINC: open Biolink ticket, biolink/biolink-model#334; will not be a Biolink issue if we adopt LOINC2HPO

from plater.

EvanDietzMorris avatar EvanDietzMorris commented on July 29, 2024

Example queries are generated based on the SRI testing data file specific to that plater now, so the examples should always be valid.

from plater.

maximusunc avatar maximusunc commented on July 29, 2024

Yep, can confirm that the example query for automat icees-kg works. Thanks Evan!

from plater.

karafecho avatar karafecho commented on July 29, 2024

Thanks, all. Looks good now.

from plater.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.