Code Monkey home page Code Monkey logo

Comments (2)

gaurav avatar gaurav commented on August 23, 2024

I think the problem is in the limit parameter -- I don't think we intend to support -1 as a valid limit, but we use it as a facet limit, which seems to hit some kind of limit with our current Solr queries. I think this causes this query to fail where the number of results hit some internal limit; this works correctly with "HIV/AIDS" since that matches far fewer synonyms than either "HIV" or "human immunodeficiency virus". But both of those queries work with non-negative limits, up to our maximum (1000).

Do you really need to be able to return all synonyms? If so, we're currently planning to remove that functionality in PR #46, which will no longer allow negative limits, so we should make sure we can still support your use-case!

I tried to work around this by changing the offset parameter, but I ran into an error message when I tried to do that. So I'll fix that before I close this issue. Thank you for reporting it!

  • Fix error caused by increasing offset values.

from nameresolution.

GitHubbit avatar GitHubbit commented on August 23, 2024

I used this when Clinical KPs (ICEES, COHD, and EHR Risk) were attempting to determine how much overlap we had amongst us 3 providers given the test case of: What drugs treat asthma? To maximize overlap, we returned all possible synonyms. That certainly helped improve overlap, and further begs the question: should Clinical Evidence be stronger when Clinical KPs agree on an edge, and how might this be used by O&O? That maaaay be a future consideration. In short, at present, we do not need this, but I wanted to provide context in case it pops up again in the future :) Thank you for the response and help, and I went ahead and set the non-negative maximum I needed for this particular case.
-Kamileh from Multiomics

from nameresolution.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.