Code Monkey home page Code Monkey logo

Comments (4)

cbizon avatar cbizon commented on July 22, 2024 1

I think it is being used to order the synonyms when they get grouped by curie. But I think if we put all the names in one document we wouldn't need to do that (and could therefore lose it). I think that it's worth giving this a shot and seeing whether it works or not.

from nameresolution.

cbizon avatar cbizon commented on July 22, 2024

Of course the downside here is that it makes the solr documents even that much bigger

from nameresolution.

cbizon avatar cbizon commented on July 22, 2024

The current docs look like this, I think:

{
  "curie": "CHEBI:74925",
  "length": 42,
  "id": 192534,
  "name": "beta-site APP-cleaving enzyme 1 inhibitors"
 },
 {
  "curie": "CHEBI:74925",
  "length": 22,
  "id": 192535,
  "name": "EC 3.4.23.46 inhibitor"
 },
 {
  "curie": "CHEBI:74925",
  "length": 23,
  "id": 192536,
  "name": "EC 3.4.23.46 inhibitors"
 },
 {
  "curie": "CHEBI:74925",
  "length": 36,
  "id": 192537,
  "name": "EC 3.4.23.46 (memapsin 2) inhibitors"
 },

If we need to add the type and preferred name to every element, then oof.

I wonder if we could transform the docs to something more like

{ 
  curie: ....
  names: [ "name1", "name2", "name3"]
  type: ""
  preferred name:
}

That way the percent diff of adding the new info is paid for in the reduction of curie repetition.

from nameresolution.

gaurav avatar gaurav commented on July 22, 2024

If we need to add the type and preferred name to every element, then oof.

The other option would be for NameRes to include a Redis table that has id to canonical name + biolink type mappings, but that would complicate the backend.

I wonder if we could transform the docs to something more like

I like this! NameRes is loaded from the synonym file, which is currently in the format:

id [tab] synonym type [tab] synonym

I think we if modify this to:

id [tab] biolink type [tab] canonical label [tab] synonym type [tab] synonym

We could use Solr updates to load it in the format you suggest. The synonym files would then get much larger, but the Solr database -- which is the piece we have to transfer from RENCI to ITRB -- might end up being smaller because it has fewer documents in it.

Is it okay to drop the length field? Is it currently being used?

from nameresolution.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.