Comments (2)
We can detect page language only when page will loaded.
Context menu contains button to control page translation state and show current state.
What exactly behavior you are expects if i will press button "translate page" and then i will open context menu again while page loading?
If your expectation is state must be "stop translation", it may be confused, because page state may be inconsistent between context menu button and popup button
from linguist.
What exactly behavior you are expects if i will press button "translate page" and then i will open context menu again while page loading?
Page translation gets scheduled. When you open the menu again, there's a button to cancel the scheduled translation. If the page, upon getting loaded, turns out to be already in the target language, then do nothing.
If your expectation is state must be "stop translation", it may be confused, because page state may be inconsistent between context menu button and popup button
Sorry, I didn't get this part. Are you talking about the current behavior?
Either way, I pointed out that
However, you can still translate the page by clicking "Translate page" in the extension popup while it's still loading (although still you have to wait for a bit, but not as long as until the context menu item appears).
So I believe at least the context menu item and the extension popup (the one that gets open when you click on the extension in the extensions bar) should provide the "translate page" button at the same time.
from linguist.
Related Issues (20)
- (Android) none of the drop down box clickable
- Google translator incorrect translate HTML chars (like `<` and `>`)
- Incorrect Linguist name for Korean language
- "Selected text translation" should not reset selection (Gecko) HOT 7
- feat: translate on hover HOT 4
- [Feature request] Use multiple translators with different priorities HOT 7
- Add Safari support HOT 1
- Modal window for custom translators code have too small height
- Move custom translators to other repository
- Allow to choose different translators for page translation and text translation
- "Page translation" tab doesn't show up when the page finishes loading HOT 1
- Incorrect translation on Reddit and some websites. HOT 5
- Use domtranslator library
- Show words defenitions
- Add translation controls on page for mobile
- Can't click button to translate selected text
- Divide the history to a sections by date
- Not able to register Ctrl/Alt/Shift as keybindings when RFP on firefox is set to True HOT 4
- Open links from addon popup in a current tab
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from linguist.