Code Monkey home page Code Monkey logo

Comments (2)

vitonsky avatar vitonsky commented on September 25, 2024

We can detect page language only when page will loaded.
Context menu contains button to control page translation state and show current state.

What exactly behavior you are expects if i will press button "translate page" and then i will open context menu again while page loading?

If your expectation is state must be "stop translation", it may be confused, because page state may be inconsistent between context menu button and popup button

from linguist.

WofWca avatar WofWca commented on September 25, 2024

What exactly behavior you are expects if i will press button "translate page" and then i will open context menu again while page loading?

Page translation gets scheduled. When you open the menu again, there's a button to cancel the scheduled translation. If the page, upon getting loaded, turns out to be already in the target language, then do nothing.

If your expectation is state must be "stop translation", it may be confused, because page state may be inconsistent between context menu button and popup button

Sorry, I didn't get this part. Are you talking about the current behavior?

Either way, I pointed out that

However, you can still translate the page by clicking "Translate page" in the extension popup while it's still loading (although still you have to wait for a bit, but not as long as until the context menu item appears).

So I believe at least the context menu item and the extension popup (the one that gets open when you click on the extension in the extensions bar) should provide the "translate page" button at the same time.

from linguist.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.