Code Monkey home page Code Monkey logo

Comments (11)

tpope avatar tpope commented on May 29, 2024

You probably want :Start bash rather than :Dispatch bash, seeing as how it's an interactive command. Still, strange error. Do you have any mc references in your bash config?

from vim-dispatch.

krismalfettone avatar krismalfettone commented on May 29, 2024

None. Is there a way to turn on some sort of logging to tell exactly what command/args are being run?

By the way, I forgot to mention it before but your plugin is awesome / very useful.

from vim-dispatch.

krismalfettone avatar krismalfettone commented on May 29, 2024

The closest thing I have found is some env function midnight-commander seems to put into my env. I do not use midnight-commander, but it is installed on this system.

mc=() { . /usr/share/mc/bin/mc-wrapper.sh
}
_=/usr/bin/env

Found via: http://stackoverflow.com/questions/9306717/malformed-environment-variables-detection-in-python

Do you read in the environment variables then try to duplicate them in some way?

from vim-dispatch.

krismalfettone avatar krismalfettone commented on May 29, 2024

Could it potentially be in autoload/dispatch.vim

function! dispatch#isolate(...)
let command = ['cd ' . shellescape(getcwd())]
for line in split(system('env'), "\n")
let var = matchstr(line, '^\w+\ze=')
if !empty(var) && var !=# '_'
if &shell =~# 'csh'
let command += ['setenv '.var.' '.shellescape(eval('$'.var))]
else
let command += ['export '.var.'='.shellescape(eval('$'.var))]
endif
endif
endfor
let command += a:000
let temp = tempname()
call writefile(command, temp)
return 'env -i ' . &shell . ' ' . temp
endfunction

It looks like you are duplicate the environment vars and assuming they are all on one line. But for some reason this one is not, and valid I guess.

from vim-dispatch.

krismalfettone avatar krismalfettone commented on May 29, 2024

Also, after doing 'unset mc'. Everything works fine. So that must be the culprit.

from vim-dispatch.

krismalfettone avatar krismalfettone commented on May 29, 2024

Perhaps listing getting the list of environment vars with something similar to:
http://stackoverflow.com/questions/11175842/how-to-list-all-the-environment-variables-in-vim

Then looping over them one by one would allow you to handle multi-line ones easier?

from vim-dispatch.

tpope avatar tpope commented on May 29, 2024

I don't think the environment variable listing in particular is the problem, as we're only matching lines containing =, and getting the values directly from vim. What does :echo $mc report? How about :echo shellescape($mc)?

from vim-dispatch.

justinmk avatar justinmk commented on May 29, 2024

@tpope I've narrow this down to a problem with exported bash functions. I'm getting a similar issue with fzf which defines a bash function fzf and exports it:

fzf() {
  /usr/bin/ruby /Users/justin/.fzf/fzf "$@"       
} 
export -f fzf > /dev/null

Killing vim, then unset fzf, then restarting Vim, allows :Make to run without problems[1]. Non-exported functions aren't picked up by Vim's environment, so dispatch.vim doesn't have a problem with them.

I'm guessing that dispatch.vim's isolate() logic introduced in #9 may be related. (Or it's a coincidence that @krismalfettone reported this a few days later.)

What does :echo $mc report? How about :echo shellescape($mc)?

In my case, :echo $fzf gives:

() {  /usr/bin/ruby /Users/justin/.fzf/fzf "$@"
}

:echo shellescape($fzf) gives:

'() {  /usr/bin/ruby /Users/justin/.fzf/fzf "$@"\
}'

[1] For reference: there is discussion on vim_dev about adding the ability to unset env vars from within vim: https://groups.google.com/d/msg/vim_dev/IIrDqVvdpOo/Q2nuImgZEtEJ

from vim-dispatch.

tpope avatar tpope commented on May 29, 2024

I've seen this shell escaping issue before. The only mystery to me is what the hell this weird function as environment variable thing is. Doesn't happen in zsh so I assume it's some bash misfeature.

from vim-dispatch.

justinmk avatar justinmk commented on May 29, 2024

Thanks, but I'm still getting unexpected EOF. If I open the temp file, I think I see the issue: a NUL byte is being written instead of a newline:

export fzf='() {  /usr/bin/ruby /Users/justin/.fzf/fzf "$@"^@}'

from vim-dispatch.

justinmk avatar justinmk commented on May 29, 2024

It works. Thanks so much!

from vim-dispatch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.