Code Monkey home page Code Monkey logo

Comments (10)

tpope avatar tpope commented on May 31, 2024

When should it run the Post? After dispatching? After the results are in? There's no guarantee of the latter so that's a non-starter for cleanup tasks.

I had this for a while but yanked it out, as I couldn't find a way to satisfy all use cases. I think the best bet is to come up with a new set of autocommands.

from vim-dispatch.

dhruvasagar avatar dhruvasagar commented on May 31, 2024

QuickFixCmdPost is supposed to be triggered after running any of the quickfix commands like :make, :lmake etc. I am using this in my gem https://github.com/dhruvasagar/vim-markify where I process the quickfix (or location list) in this autocommand to mark all errors using signs.

I suppose I could use vimresize like you are, but based on the usual vim-flow, seems like these autocommands should be triggered as they are meant to...

from vim-dispatch.

tpope avatar tpope commented on May 31, 2024

Yes, that's one way to use it. Another way is https://github.com/tpope/vim-bundler/blob/master/plugin/bundler.vim#L471-L479. If I add support for your requirements, it breaks the current working directory with mine. (You can debate the merits of my technique, but I doubt I am the only one using it.)

This is why I say it would be better to have different events. Then I can opt into the one I need and you can opt into the one you need.

I assume you would actually like an event that fires on :Copen as well, correct? This means that you would get marks even when loading a partially complete run.

from vim-dispatch.

dhruvasagar avatar dhruvasagar commented on May 31, 2024

Pardon me, but I am not completely sure if I follow. How will QuickFixCmdPost event in markify break the current working directory ?

Markify simply calls getqflist() or getloclist(0) and processes the list to place the signs.

from vim-dispatch.

tpope avatar tpope commented on May 31, 2024

Calling doautocmd QuickFixCmdPre make in dispatch.vim will break the current working directory for anyone with bundler.vim installed.

from vim-dispatch.

dhruvasagar avatar dhruvasagar commented on May 31, 2024

So would you then suggest me to tap into VimResize in case dispatch is installed ?

from vim-dispatch.

tpope avatar tpope commented on May 31, 2024

Absolutely not. You'll get false positives, false negatives, and only support tmux.

This is an easily solvable problem if you would just answer my questions.

from vim-dispatch.

dhruvasagar avatar dhruvasagar commented on May 31, 2024

Well I need to process the quickfix / location lists after they've been populated to place the signs.
So if you are to use a new autocommand, it should run after the quickfix list has been populated.

from vim-dispatch.

tpope avatar tpope commented on May 31, 2024

Okay, I'm now firing QuickFixCmdPost cgetfile. It's a weird name but I figured mapping to the underlying operation was as good as anything. I'm omitting QuickFixCmdPre until someone needs it.

from vim-dispatch.

dhruvasagar avatar dhruvasagar commented on May 31, 2024

Thanks :)

from vim-dispatch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.