Code Monkey home page Code Monkey logo

Comments (4)

TorstenDittmann avatar TorstenDittmann commented on May 11, 2024

Hello,

Thanks for the submission, are you sure you are not blocking access to LocalStorage as well?

Since I cannot think of a reason right now that disabled cookies will break the app. Cookies are only used for the Cloud Login, and we also have an automatic fallback for LocalStorage if cookies are disabled.

Based on the yellow error message, do you mind checking again if LocalStorage is also disabled?

Because that will break the app 100% right now and I didn't think about that LocalStorage might be disabled, until now.

from omniawrite.

jish avatar jish commented on May 11, 2024

Ah, yes. That seems correct. It appears that accessing local storage causes an error. No error appears to be thrown when attempting to set a cookie:

document.cookie = "foo=bar";
// Request to access cookie or storage on “<URL>” was blocked because we are blocking all storage access requests. 3

window.localStorage.set("foo", "bar");
// Uncaught DOMException: The operation is insecure.

Screen Shot 2020-10-08 at 1 52 40 PM

from omniawrite.

TorstenDittmann avatar TorstenDittmann commented on May 11, 2024

Thanks for clarifying, that makes sense 🙂

I think, the best way to solve this is showing the user a modal/text that LocalStorage needs to be activated to use OmniaWrite.

I don't think running the app with the whole data in memory makes that much sense. Especially when there are reloads necessary for certain actions inside the app.

This should probably be checked outside of the actual runtime of the app and be done before the app even loads, that will prevent unknown scenarios where the app will still break.

from omniawrite.

PineappleIOnic avatar PineappleIOnic commented on May 11, 2024

I wouldn't mind having a look into this being done if you would like 👍

from omniawrite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.