Comments (2)
Hi,
I'm not maintainer of this repository but I recently worked on "comments", a similar issue (#41)
I think 'author' like 'comment' could be an array or a single entry.
I dont make the test, but I'm pretty sure that the current release only support one author.
- 'Article' is a 'Creative Work' child.
- 'autor' and 'comment' are 'Creative Work' properties.
I think you will have to improve source code and suggest a pull request with following update:
-
Improve 'Creative Work' for authors like I have done for comments
cf.
https://github.com/Torann/json-ld/blob/master/src/ContextTypes/CreativeWork.php
(add a setAuthorAttribute(..) similar to addCommentAttribute(..)) -
update a unit test to have 2 or N authors usecase like for the following test where we have 2 comments
https://github.com/Torann/json-ld/blob/master/tests/ContextTypes/ArticleTest.php
Of course we could certainely investigate deeper to make this pattern (array of value) available by default for all properties of a context, but I'ven't done this analysis ;)
Hope this will help/unlock you.
regards
from json-ld.
Thank you so much for taking the time to comment extensively and make a PR to make this functionality possible.
Hopefully, the maintainer pulls your changes so this will work. Thank you so much!
from json-ld.
Related Issues (20)
- LodgingBusiness ContextType HOT 2
- description and image property missing for type "event" HOT 2
- Support more Syntax Tokens and Keywords HOT 1
- Support ItemList HOT 1
- Print only contents and not tag HOT 1
- question about unexpected "</script>"
- Support arrays: example 1 article embeds N comments HOT 1
- unique review in Article schema HOT 1
- gratipay link in README not working HOT 2
- Missing itemReviewed property for AggregateRating HOT 2
- Proposal: drop support for PHP 5.6 and move to at least 7.2 HOT 5
- Is availiable to use JobPosting type?
- Wheres the FAQ type? HOT 1
- Support VirtualLocation instead of Place
- WebPage is not a known valid target type for the itemReviewed property.
- Product.php setIsSimilarToAttributes deletes "offers"
- LocalBusiness does not allow multiple reviews
- Nesting (e.g. Review inside Book, ratings inside reviews etc.)
- Support for AggregateOffer is missing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from json-ld.