Comments (4)
I think this is expected behavior and it is the developer's responsibility to check that the shell is valid before using it.
from libsu.
I personally disagree that isDirectory()
should throw NoShellException
because SuFile
extends File
, when this issue crashed my app on someone device, I had no idea and it was a existing behavior for me, so this was very unexpected for me.
I already did my best do avoid calling SuFile
when root does not exists or is not available, and this "behavior" was really unexpected, so I think it's definitely a flaw of the library because the goal of a library is to help developers make programs.
But this is mainly a mater of opinion, so I understand the disagreement.
from libsu.
Well, SuFile
is backed by a shell; if you have no shell available, how does it operate? If you are really concerned about this, you should move over to use the nio
module.
from libsu.
Well, I reported this because SuFile
crashed despite my app checking for root access.
from libsu.
Related Issues (20)
- How do I transfer to Android tablet
- Crashing in onInit() HOT 4
- Remove ROOT_MOUNT_MASTER status HOT 1
- How do I simulate Control + C for a process HOT 3
- 使用360加固后无法绑定RootService HOT 6
- Doesn't support targetSdk>31? HOT 6
- LIBSU: java.io.InterruptedIOException HOT 2
- Access MainActivity HOT 5
- Refuses to work even though it has root. HOT 1
- LIBRARY REFUSES to access files. HOT 2
- 建议 HOT 2
- !
- [Security] Repository is vulnerable to MavenGate
- StrictMode violation: reading files from the disk in the main thread
- 希望能动态设置超时 HOT 1
- Apps using libsu do not work on root solutions like APatch. HOT 5
- NoSuchMethodException on Android 5.1.1 HOT 2
- . HOT 1
- Worst Documentation HOT 1
- System resources broken on Samsung too HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libsu.