Comments (6)
Makes sense to me. Any ideas how we can verify credentials? Should we do this in dry run as well?
And are you interested in contributing this feature? (If so, I can point you in the right direction)
from monodeploy.
ruin the 1.0.0 release of one of my monorepos
You have 72 hours to delete a release from npm.
https://docs.npmjs.com/unpublishing-packages-from-the-registry
from monodeploy.
I'd like to contribute, I glanced at the repository but I didn't spot the right place to do it fast enough to warrant making a pr before an issue :)
Semantic release does it by git push --dry-run
, which some people on StackOverflow say does not work, but it does seem to work for me.
One of my repositories:
git push --dry-run --no-verify https://github.com/edielemoine/eslint.git HEAD:test
To https://github.com/edielemoine/eslint.git
* [new branch] HEAD -> test
A repository I can't push to:
git push --dry-run --no-verify https://github.com/eslint/eslint.git HEAD:test
remote: Permission to eslint/eslint.git denied to EdieLemoine.
fatal: unable to access 'https://github.com/eslint/eslint.git/': The requested URL returned error: 403
Should we do this in dry run as well?
I use dry run to check if my config works, so knowing I can't push commits before running a real deploy would be very useful.
You have 72 hours to delete a release from npm.
I know, but it doesn't allow you to republish the same name@version
ever again :/
from monodeploy.
I glanced at the repository but I didn't spot the right place
All git commands live in this file https://github.com/tophat/monodeploy/blob/main/packages/git/src/gitCommands.ts which must also be duplicated in the mocks. You'd add a new command to verify push permissions.
The monodeploy pipeline is defined in this file: https://github.com/tophat/monodeploy/blob/main/packages/node/src/index.ts.
You could do the check in a stage before the publish to npm here:
monodeploy/packages/node/src/index.ts
Line 288 in 03c45dd
monodeploy/packages/node/src/index.ts
Line 117 in 03c45dd
The check should only run if config.git.push
is true.
An alternative approach would be to run the "verify git permissions" check in place of the real git push
when in dry run:
monodeploy/packages/node/src/index.ts
Line 308 in 03c45dd
from monodeploy.
Thanks, just opened a pr! :)
from monodeploy.
Some enhancements in https://github.com/tophat/monodeploy/releases/tag/monodeploy%403.4.0
from monodeploy.
Related Issues (20)
- Improve changelog formatting as well as default conventional config
- Simplify config and getting started guide, with examples of optimal setups
- [plugin-github] Cannot determine GitHub owner or repository HOT 2
- cannot pull with rebase: You have unstaged changes. HOT 5
- YN0001: Error: Missing workspace identity. HOT 2
- Getting started links to architecture page lead to 404
- Add more verbose logging HOT 16
- Dependency Dashboard
- Documentation ties `autocommit` and `persistVersions` together unnecessarily
- Alllow for committing changelogs without persisting versions
- Race condition exists for autocommits if future changes are merged before the autocommit HOT 3
- Architecture diagram on website is outdated
- Failure in prepack script, not failing monodeploy
- $INIT_CWD not being set in prepack lifecycle script HOT 1
- Changelog links are broken on GitLab (and possibly other platforms) HOT 5
- Monodeploy modifies pnp file HOT 2
- Auto-generated configuration docs don't render defaults correctly
- enableTransparentWorkspaces=false does not work when attempting to publish a major version HOT 1
- Stuck during package installation. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from monodeploy.