Code Monkey home page Code Monkey logo

Comments (3)

g3gg0 avatar g3gg0 commented on September 28, 2024 2

i can understand your impression. it might be right, maybe not. not sure.

We have the UID in different representation to be handled. As UID-string, as rUID-string as rUID bytes.
Quite a mix depending on what it's used for. That is also a bit pain for me.

And yeah, maybe uint64 might be the best choice plus some conversion routines back and forth.
If you could go through the code and check if it in the end gives cleaner code, it would be fine for me.

from teddycloud.

SciLor avatar SciLor commented on September 28, 2024

Both representations are used for different purposes, the one to compare and the one to identify physical files.
But I see no problem streamlining it into a a UID uint64 representation, as this could clean up the code a bit.

I currently don't see that this would fix the lower/uppercase problem, we check for path existence for an UID, not checking each file/dir.

from teddycloud.

pepe82sh avatar pepe82sh commented on September 28, 2024

The idea was that if you compare uint64 rather than strings you have no case anymore. But that might be easier said than done. Just looked at some code in handler_cloud.c and it seemed more complicated that it'd need to be. As stated previously, I'm not that deep into the code base and it might be a "Schnapsidee". I'll give it a try once I have some time.

from teddycloud.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.