Code Monkey home page Code Monkey logo

Comments (2)

tomwojcik avatar tomwojcik commented on May 22, 2024

I haven't been using any asgi for over a year now but if I had to guess - background tasks are not as background as it seems. They still run within the request-response cycle. They are initialized just after the response has been sent (asynchronously). It's the same event loop, so "the context of the context" will be available. If one of these tasks was doing some computation ( or time.sleep(5)) your worker would be blocked as its event loop would be blocked.

https://github.com/encode/starlette/blob/881af38cc2e038de1f02e4fba7b7dab2df79b38a/starlette/responses.py#L148-L159

If I understand it correctly, response.__call__ is exactly what self.app(scope, receive, send_wrapper) is doing, so the context hasn't been reset yet.

try:
await self.app(scope, receive, send_wrapper)
finally:
_request_scope_context_storage.reset(token)

So yeah, although surprising, it makes sense.

from starlette-context.

hhamana avatar hhamana commented on May 22, 2024

ooh, I see. The background task is processed right after, literally the next line after the response is sent, which as seen from the middleware, is still in the try block. the reset is only after, in the finally block, which ends up executed after the response AND the background task.
I understand now, and feel I can sleep soundly again.

from starlette-context.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.