disallow `orderAggregate` with `distinctAggregator` about haskell-opaleye HOT 10 CLOSED

Great, glad it works for you.

from haskell-opaleye.

Or perhaps we can deprecate distinctAggregator in favour of distinctOn? I can't think any case distinctAggregator can do but distinctOn can't

from haskell-opaleye.

Can you please share a small example that generates this crashing code?

from haskell-opaleye.

Yes, just clone https://github.com/stevemao/opaleye-order-distinct-aggregator and run docker compose up.

from haskell-opaleye.

Thanks. I believe this will be fixed by #586. Perhaps you'd like to try it.

from haskell-opaleye.

@tomjaguarpaw still the same error https://github.com/stevemao/opaleye-order-distinct-aggregator/tree/aggregate

from haskell-opaleye.

Could you double check? This works fine, for example: a9e6fe2

(I don't have the ability to run Docker here)

from haskell-opaleye.

(And see here for the test run: https://github.com/tomjaguarpaw/haskell-opaleye/actions/runs/7669040691)

from haskell-opaleye.

If you still think there's a problem, could you come up with a failing test case that I can add to Test.hs?

from haskell-opaleye.

My bad. it is indeed working now https://github.com/stevemao/opaleye-order-distinct-aggregator/actions/runs/7676483130/job/20924091643

from haskell-opaleye.