Comments (22)
tomblind
commented on August 15, 2024
1
I managed to get busted working with 5.3 and reproduce your issue. Unfortunately, I don't think debugging using the interpreter in this way will work. When busted.runner is required, it re-evaluates any code passed to lua's command line, which runs a second debugger hook. Unfortunately, this second hook doesn't get access to the busted environment, hence the error.
However, I have fixed the original issue that occurred when running via the busted cli (6ac5b86) and it will be in the next release (which I hope to do today or tomorrow). With this fix, you can also run using a lua interpreter, but you have to set it up as a custom environment (use "command": "lua" in launch.json instead of "lua": "lua").
from local-lua-debugger-vscode.
astrochili
commented on August 15, 2024
1
@tomblind @dainkaplan I confirm. This is my configuration that works fine. Breakpoints work, busted works. Thanks!
launch.json:
{
"configurations": [
{
"name": "Busted",
"type": "lua-local",
"request": "launch",
"program": {
"command": "busted"
},
"args": [
"${workspaceFolder}/test/start.lua"
],
}
]
}start.lua:
if os.getenv("LOCAL_LUA_DEBUGGER_VSCODE") == "1" then
require("lldebugger").start()
end
describe("a test", function()
-- tests to here
end)from local-lua-debugger-vscode.
tomblind
commented on August 15, 2024
I've attempted to reproduce this, but it seems to work fine for me. 😄
What happens when the debugger 'halts'? Is there an error? Can you set "verbose": true in the launch.json and post the log from the debug console?
from local-lua-debugger-vscode.
dainkaplan
commented on August 15, 2024
I’ll check the latest and see what whats what! Will report back. Thanks for looking into it, @tomblind
from local-lua-debugger-vscode.
astrochili
commented on August 15, 2024
@tomblind I can provide the case. My lunch.json:
{
"configurations": [
{
"name": "Test",
"type": "lua-local",
"request": "launch",
"program": {
"command": "busted"
},
"args": [
"${workspaceFolder}/test/start.lua"
],
"verbose": true
}
]
}
My test/start.lua:
if os.getenv("LOCAL_LUA_DEBUGGER_VSCODE") == "1" then
require("lldebugger").start()
end
describe("a test", function()
-- tests to here
end)
Busted falls on describe() or it() call. This is verbose output:
[request] launchRequest
[request] setBreakPointsRequest
[request] configurationDoneRequest
[info] launching `"busted" /Users/.../test/start.lua` from "/Users/..."
[info] process launched
[request] threadsRequest
[message] {"tag":"$luaDebug","message":"step","type":"debugBreak","threadId":1,"breakType":"step"}
[command] break clear
[message] {"tag":"$luaDebug","type":"breakpoints","breakpoints":[]}
[command] break set /usr/local/share/lua/5.3/busted/init.lua:65
[message] {"tag":"$luaDebug","type":"breakpoints","breakpoints":[{"file":"/usr/local/share/lua/5.3/busted/init.lua","enabled":true,"line":65}]}
[command] cont
[message] {"tag":"$luaDebug","message":"\nstack traceback:\n\t/usr/local/share/lua/5.3/busted/core.lua:268: in global 'describe'\n\t/Users/.../test/start.lua:5: in main chunk\n\t[C]: in function 'xpcall'\n\t/usr/local/share/lua/5.3/busted/core.lua:178: in field 'safe'\n\t/usr/local/share/lua/5.3/busted/block.lua:146: in field 'execute'\n\t/usr/local/share/lua/5.3/busted/init.lua:7: in upvalue 'executor'\n\t/usr/local/share/lua/5.3/busted/core.lua:312: in function </usr/local/share/lua/5.3/busted/core.lua:312>\n\t[C]: in function 'xpcall'\n\t/usr/local/share/lua/5.3/busted/core.lua:178: in field 'safe'\n\t/usr/local/share/lua/5.3/busted/core.lua:312: in field 'execute'\n\t/usr/local/share/lua/5.3/busted/execute.lua:58: in local 'execute'\n\t/usr/local/share/lua/5.3/busted/runner.lua:197: in function 'busted.runner'\n\t/usr/local/lib/luarocks/rocks-5.3/busted/2.0.0-1/bin/busted:3: in main chunk\n\t[C]: in ?","type":"debugBreak","threadId":1,"breakType":"error"}
[error]
stack traceback:
/usr/local/share/lua/5.3/busted/core.lua:268: in global 'describe'
/Users/.../test/start.lua:5: in main chunk
[C]: in function 'xpcall'
/usr/local/share/lua/5.3/busted/core.lua:178: in field 'safe'
/usr/local/share/lua/5.3/busted/block.lua:146: in field 'execute'
/usr/local/share/lua/5.3/busted/init.lua:7: in upvalue 'executor'
/usr/local/share/lua/5.3/busted/core.lua:312: in function </usr/local/share/lua/5.3/busted/core.lua:312>
[C]: in function 'xpcall'
/usr/local/share/lua/5.3/busted/core.lua:178: in field 'safe'
/usr/local/share/lua/5.3/busted/core.lua:312: in field 'execute'
/usr/local/share/lua/5.3/busted/execute.lua:58: in local 'execute'
/usr/local/share/lua/5.3/busted/runner.lua:197: in function 'busted.runner'
/usr/local/lib/luarocks/rocks-5.3/busted/2.0.0-1/bin/busted:3: in main chunk
[C]: in ?
[request] threadsRequest
[command] threads
[message] {"tag":"$luaDebug","threads":[{"active":true,"id":1,"name":"main thread"}],"type":"threads"}
[request] stackTraceRequest 0/20 (thread 1)
[command] thread 1
[message] {"tag":"$luaDebug","frames":[{"line":268,"active":true,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"describe"},{"source":"/Users/.../test/start.lua","line":5},{"line":-1,"source":"[C]","func":"xpcall"},{"line":178,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"safe"},{"line":146,"source":"/usr/local/share/lua/5.3/busted/block.lua","func":"execute"},{"line":7,"source":"/usr/local/share/lua/5.3/busted/init.lua","func":"executor"},{"source":"/usr/local/share/lua/5.3/busted/core.lua","line":312},{"line":-1,"source":"[C]","func":"xpcall"},{"line":178,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"safe"},{"line":312,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"execute"},{"line":58,"source":"/usr/local/share/lua/5.3/busted/execute.lua","func":"execute"},{"source":"/usr/local/share/lua/5.3/busted/runner.lua","line":197},{"source":"/usr/local/lib/luarocks/rocks-5.3/busted/2.0.0-1/bin/busted","line":3},{"source":"[C]","line":-1}],"type":"stack"}
[request] evaluateRequest items
[command] thread 1
[message] {"tag":"$luaDebug","frames":[{"line":268,"active":true,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"describe"},{"source":"/Users/.../test/start.lua","line":5},{"line":-1,"source":"[C]","func":"xpcall"},{"line":178,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"safe"},{"line":146,"source":"/usr/local/share/lua/5.3/busted/block.lua","func":"execute"},{"line":7,"source":"/usr/local/share/lua/5.3/busted/init.lua","func":"executor"},{"source":"/usr/local/share/lua/5.3/busted/core.lua","line":312},{"line":-1,"source":"[C]","func":"xpcall"},{"line":178,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"safe"},{"line":312,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"execute"},{"line":58,"source":"/usr/local/share/lua/5.3/busted/execute.lua","func":"execute"},{"source":"/usr/local/share/lua/5.3/busted/runner.lua","line":197},{"source":"/usr/local/lib/luarocks/rocks-5.3/busted/2.0.0-1/bin/busted","line":3},{"source":"[C]","line":-1}],"type":"stack"}
[command] frame 1
[message] {"tag":"$luaDebug","frames":[{"line":268,"active":true,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"describe"},{"source":"/Users/./test/start.lua","line":4..4},{"line":-1,"source":"[C]","func":"xpcall"},{"line":178,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"safe"},{"line":146,"source":"/usr/local/share/lua/5.3/busted/block.lua","func":"execute"},{"line":7,"source":"/usr/local/share/lua/5.3/busted/init.lua","func":"executor"},{"source":"/usr/local/share/lua/5.3/busted/core.lua","line":312},{"line":-1,"source":"[C]","func":"xpcall"},{"line":178,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"safe"},{"line":312,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"execute"},{"line":58,"source":"/usr/local/share/lua/5.3/busted/execute.lua","func":"execute"},{"source":"/usr/local/share/lua/5.3/busted/runner.lua","line":197},{"source":"/usr/local/lib/luarocks/rocks-5.3/busted/2.0.0-1/bin/busted","line":3},{"source":"[C]","line":-1}],"type":"stack"}
[command] eval items
[message] {"tag":"$luaDebug","type":"result","result":{"type":"nil","value":"nil"}}
[request] scopesRequest
[command] thread 1
[message] {"tag":"$luaDebug","frames":[{"line":268,"active":true,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"describe"},{"source":"/Users/.../test/start.lua","line":5},{"line":-1,"source":"[C]","func":"xpcall"},{"line":178,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"safe"},{"line":146,"source":"/usr/local/share/lua/5.3/busted/block.lua","func":"execute"},{"line":7,"source":"/usr/local/share/lua/5.3/busted/init.lua","func":"executor"},{"source":"/usr/local/share/lua/5.3/busted/core.lua","line":312},{"line":-1,"source":"[C]","func":"xpcall"},{"line":178,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"safe"},{"line":312,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"execute"},{"line":58,"source":"/usr/local/share/lua/5.3/busted/execute.lua","func":"execute"},{"source":"/usr/local/share/lua/5.3/busted/runner.lua","line":197},{"source":"/usr/local/lib/luarocks/rocks-5.3/busted/2.0.0-1/bin/busted","line":3},{"source":"[C]","line":-1}],"type":"stack"}
[command] frame 1
[message] {"tag":"$luaDebug","frames":[{"line":268,"active":true,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"describe"},{"source":"/Users/.../test/start.lua","line":5},{"line":-1,"source":"[C]","func":"xpcall"},{"line":178,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"safe"},{"line":146,"source":"/usr/local/share/lua/5.3/busted/block.lua","func":"execute"},{"line":7,"source":"/usr/local/share/lua/5.3/busted/init.lua","func":"executor"},{"source":"/usr/local/share/lua/5.3/busted/core.lua","line":312},{"line":-1,"source":"[C]","func":"xpcall"},{"line":178,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"safe"},{"line":312,"source":"/usr/local/share/lua/5.3/busted/core.lua","func":"execute"},{"line":58,"source":"/usr/local/share/lua/5.3/busted/execute.lua","func":"execute"},{"source":"/usr/local/share/lua/5.3/busted/runner.lua","line":197},{"source":"/usr/local/lib/luarocks/rocks-5.3/busted/2.0.0-1/bin/busted","line":3},{"source":"[C]","line":-1}],"type":"stack"}
[request] variablesRequest locals
[command] locals
[message] {"tag":"$luaDebug","variables":[{"type":"nil","value":"nil","name":"trace"},{"type":"table","length":0,"value":"[table: 0x7f8612651570]","name":"ctx"},{"type":"function","value":"[function: 0x7f861245b1e0]","name":"fn"},{"type":"string","value":"\"Test case\"","name":"name"}],"type":"variables"}
By the way, without this code
if os.getenv("LOCAL_LUA_DEBUGGER_VSCODE") == "1" then
require("lldebugger").start()
end
busted runs fine from VSCode, but without debugger of course.
from local-lua-debugger-vscode.
tomblind
commented on August 15, 2024
Ok, I do get the error using the busted cli. It turns out it's not an error at all: busted is using lua's debug library to get a callstack and this falsely triggers a debug break, because that's one way the debugger detects errors when running code outside of an xpcall. If you hit F5 and continue, the test script will still run and can be debugged.
The easiest workaround for this right now is to run busted using a lua interpreter instead of the busted cli, since this uses xpcall for error trapping. So, in your, launch.json:
"program": {
"lua": "lua",
"file": "${workspaceFolder}/test/start.lua"
}and then in start.lua:
require("busted.runner")()It looks like this is how @dainkaplan was doing it originally though, so I'm not sure why the error occurred for him.
I'll have to think on this more, since it would be good to support running from the custom cli.
from local-lua-debugger-vscode.
dainkaplan
commented on August 15, 2024
I haven’t been able to retest yet but hope to get to this finally this weekend! As @tomblind said that’s exactly how I was trying to run it. You’re using lua51?
from local-lua-debugger-vscode.
tomblind
commented on August 15, 2024
Yup - lua51
Make sure you don't use
if os.getenv("LOCAL_LUA_DEBUGGER_VSCODE") == "1" then
require("lldebugger").start()
endwhen running this way. It's not necessary when using the lua interpreter and could cause this issue to still arise.
from local-lua-debugger-vscode.
astrochili
commented on August 15, 2024
@tomblind @dainkaplan Guys, I tried your suggestion to use lua lunching instead CLI. This is what happens:
https://drive.google.com/file/d/1H_tJAbdvA9iXIyEoWWY_fQL6JxMCyWIl/view?usp=sharing
I use Lua 5.3 and can't test it with Lua 5.1 at this moment. Any ideas?
from local-lua-debugger-vscode.
tomblind
commented on August 15, 2024
I can't access the doc - can you post it here?
from local-lua-debugger-vscode.
astrochili
commented on August 15, 2024
I can't access the doc - can you post it here?
That's a video, I updated the sharing settings, try again please :)
from local-lua-debugger-vscode.
tomblind
commented on August 15, 2024
Oops. The environment isn't being set properly. I have a fix for that but haven't pushed it yet. Sorry 😄
from local-lua-debugger-vscode.
tomblind
commented on August 15, 2024
Actually I was wrong - the environment issue should not a problem when running in lua-interpreter mode.
Looking more closely at your video - there's something strange going on in the call stack. It looks like the debugger is rehooking a second time, which is probably messing up the environment. I have no idea off the top of my head why that would happen, though. It could be a lua5.3 thing - I'll have to figure out how to get that working and see.
from local-lua-debugger-vscode.
astrochili
commented on August 15, 2024
Actually I was wrong - the environment issue should not a problem when running in lua-interpreter mode.
Looking more closely at your video - there's something strange going on in the call stack. It looks like the debugger is rehooking a second time, which is probably messing up the environment. I have no idea off the top of my head why that would happen, though. It could be a lua5.3 thing - I'll have to figure out how to get that working and see.
I'd like to help you with testing. I tried to install busted via luarocks for lua 5.1 but without success.
from local-lua-debugger-vscode.
astrochili
commented on August 15, 2024
@tomblind sounds good. I’ll be back with feedback when the update will be available.
from local-lua-debugger-vscode.
astrochili
commented on August 15, 2024
@tomblind I’d like to say again that your extension is the only one that works from the all that I tried. I don't know what kind of magic it is, but thank you! I actively use it.
from local-lua-debugger-vscode.
tomblind
commented on August 15, 2024
Thanks! My goal is make it as easy to use for common cases as possible, since most of the other debuggers available require dependencies and setup just to get them to work at all.
I've just pushed the new release. Let me know if it works for you.
from local-lua-debugger-vscode.
dainkaplan
commented on August 15, 2024
@tomblind With your latest changes I've confirmed I can run a test with:
"program": {
"command": "busted"
},
"args": ["spec/index_spec.lua"]
However, only breakpoints in the file passed as an argument to busted seems to work. Within the index_spec.lua, I have some require("other_test") to run the other tests, and all code included via require() seems to be entirely ignored.
Not sure on the source of this error yet, though! Will investigate a bit more.
from local-lua-debugger-vscode.
tomblind
commented on August 15, 2024
How does that work? When I try to require additional tests from the first, I get attempt to call a nil value (global 'describe') in the second script (not even with the debugger - just running busted from the command line).
from local-lua-debugger-vscode.
tomblind
commented on August 15, 2024
@dainkaplan Did you ever find out what was going on with the additional required tests? I was still never able to get that to work with busted in general. If that's something busted supports, I'd like to get it working with the debugger as well.
from local-lua-debugger-vscode.
mbsteixeira
commented on August 15, 2024
I also do not get to debug any lua lib.
If I execute the code below :
local debug = require("lldebugger")
debug.start()
--- debug ok
debug.stop() -- try to debug here
I also do not get to debug the debug.stop() execution .
from local-lua-debugger-vscode.
tomblind
commented on August 15, 2024
@mbsteixeira I'm not sure I understand. Once debug.stop() is called, you cannot debug anymore. That is expected behavior. In any case, it would be best to open a new issue for this.
from local-lua-debugger-vscode.
Related Issues (20)
- Extreme slowdown withing Love2d / breakpoints ignored HOT 9
- Configuration Question, trying to debug lua in DCS HOT 2
- Support for multiple threads? HOT 2
- Breakpoints don't work when program.file is set to relative parent path HOT 4
- rawlen usage makes extension incompatible with LuaJIT-based implementations
- strict mode incompatibility
- Question: is there a way to set environment variables within debugger settings? HOT 2
- love2d cant step in with debugger to love2d lua libary HOT 1
- lldebugger changes the slash in file paths in debug.traceback() when active
- Allow inspecting upvalues of a closure
- Add `console` for Integrated Terminal option to launch configuration HOT 1
- Wrong assert stack level
- Request: Example usage of customPropertyGetterForUserData
- lua5.4 supported? HOT 1
- Is this extension still developed? HOT 14
- Request to Add "console": "integratedTerminal" Functionality HOT 4
- Breakpoints not working on custom engine using physfs HOT 1
- Can't debug with Sapiens HOT 1
- Source mapping doesn't work with multiple sources in one map HOT 1
- Lua is not recognized as an internal or external command operable program or batch file
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from local-lua-debugger-vscode.