Some code refactoring about angular-leaflet-directive HOT 9 CLOSED

Looks good to me :)

from angular-leaflet-directive.

Great :)

I will show you a demo of the new code in a few days. I'm restyling your multimarkers-paths demo with the new code.

from angular-leaflet-directive.

Yep, I saw it in the dev branch :) Looking forward to the new demo!

from angular-leaflet-directive.

Hi, I have tagged the "master" version as 0.1, and will merge the "dev" branch into master soon.

houqp, could you take a look at the "examples/path-example.html"? It's based on your full-example.html, please, add or remove anything you consider important.

I have substituted the "smooth factor" with a stroke width to the watcher, but we can add any others properties of the path to the watcher if you consider them important enough.

from angular-leaflet-directive.

Just checked it out, looks a lot better than my original one, great work!

I will try to add more features in this weekend. :)

from angular-leaflet-directive.

@tombatossals , btw, in the examples, should we use:

<script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.0.6/angular.min.js"></script>`

instead of:

<script src="//ajax.googleapis.com/ajax/libs/angularjs/1.0.6/angular.min.js"></script>`

For the // case, if a user opens it directly with browser, it won't work.

from angular-leaflet-directive.

Hi, doesn't it works to you? What navigator and version are you using? The double slash URL inherits the protocol (theorically) if the browser supports the corresponding RFC.

See this thread of stackoverflow talking about this:
http://stackoverflow.com/questions/4659345/is-there-any-downside-for-using-a-leading-double-slash-to-inherit-the-protocol-i

If you think this could be a problem to some browsers let's change it. I'm always using the latest Firefox/Chrome browsers,

from angular-leaflet-directive.

It works for me if I host it using a web server, then the protocol inherited is right. But if I open it directly with firefox, the protocol will become file://, then CDN breaks ;p

from angular-leaflet-directive.

You're right, on older versions of firefox exists this problem.

Let's change the references as you say, I agree.

from angular-leaflet-directive.