How do I have to proceed about angular-leaflet-directive HOT 8 CLOSED

Any contributions follow a general pattern for GitHub projects.

1. Fork this repository
2. Make changes and do your work in the newly forked repo which will now be in your account
3. Make sure you do these changes in a new branch. This makes it easier to merge in changes from the original repository and will make submitting the final pull request easier.
4. Once you think you have your own code working and sorted out, GitHub allows you to create a pull request on this repo targeting your new branch in your own fork.
5. It'll be reviewed, maybe there will be some changes suggested. Discussion takes place. Once all it well, it would merge with this original repository.

Hope that helps!

from angular-leaflet-directive.

Ok, is this valid to discuss the different steps in the development? I send a PR per step? I mean
now you can add multiple xyz layers, no watch, no events. Next step will be add watch, next step will be add events, next add multiple overlays (layer groups in Leaflet), no watch no events, etc...

from angular-leaflet-directive.

Good question. Pull requests tend to be geared towards something that is more final to be merged in with the main master. One possibility would be to create issues here instead discussing the code you've written in your own fork.

from angular-leaflet-directive.

Hi @JaumeFigueras, I think we can create a new development branch to integrate these changes, because I suppose they would break the actual API of the module.

Does it sounds good? You could send the PR's to the new branch, and we can merge everything to the master branch when we have everything working.

If you agree, we could work on a new branch "multilayers".

from angular-leaflet-directive.

OK, on a new branch, but I will still ask for advice using github. Sorry
At the moment current changes do not break current API.

from angular-leaflet-directive.

Ok, I have created the "multilayers" branch, we can use it as a first step to add and test your code.

We could also do what @grantlucas says, create here issues with the functionality you are implementing, discuss it, we can help you with the code and later merge the changes with the main branch.

from angular-leaflet-directive.

It can be closed. Thanks to all.

from angular-leaflet-directive.

thank you for the great work @JaumeFigueras :)

from angular-leaflet-directive.