Should this work on an Electron? Can it be made to? about basic_editor HOT 4 CLOSED

It is supposed to work on the Electron, but after looking at the code I noticed that write_crtc uses OSBYTE 151 to write to the 6845 directly at $fe00/$fe01! That's going to cause problems...

Looks like it only uses it to change the cursor shape. Presumably you can do something similar on the Electron? The Beeb has VDU 23,1 for visibility/flash so I assume the Electron lets you do at least that.

--Tom

P.S. there are probably other issues lurking too...

from basic_editor.

Thanks for that — I don't think the ULA on the Electron lets you control the cursor height: you can only hide/show or make the cursor steady/flashing, so I think the simplest alternative here is to change it to steady for overwrite and flashing for insert using VDU 23.

I'll start with that and see where it gets me, thanks — I can't see any other calls to write_crtc other than to set the cursor for insert/overwrite, so that should resolve that. I can't see where it would upset the scrolling, though, but that's step 2.

I'm likely to be back but you're starting me in the write direction!

from basic_editor.

Well, replacing all that seems to have solved the two obvious problems: the cursor is now steady for overwrite and flashing for insert and make_cursor_invisble also uses VDU 23 and it's no longer crashing when it scrolls. I'm not aware of anything else that's a problem at the moment..

I'll give it a bit more of an exercise tomorrow and see if it all seems OK. If so, I'll tidy it up and send a pull request.

from basic_editor.

All done and I've sent a pull request.

The remainder of the work was sorting out the keyboard, which works very differently on the Electron: I got more involved in OSBYTE 226 and 227 than I ever wanted to, and the Advanced User Guide for the Electron is wrong about what these do, so I should probably update the BeebWiki about it.

Thanks for your help!

from basic_editor.