Code Monkey home page Code Monkey logo

Comments (11)

tolgahan-arikan avatar tolgahan-arikan commented on August 28, 2024

Thank you very much for the kind words.

Yeah sure, I think dismissing by pressing anywhere on the screen will be a good addition.
I will do this tomorrow and update the pod.

from countdownview.

mitchhankins01 avatar mitchhankins01 commented on August 28, 2024

You rock man! Seriously saved me a lot of trouble with this awesome library.

I think being able to choose whether you want to dismiss by

  • tapping anywhere on the screen or
  • tapping on a X symbol

The latter would be good so the user doesn't accidentally hit the screen. Just an idea!

from countdownview.

tolgahan-arikan avatar tolgahan-arikan commented on August 28, 2024

Would you prefer dismissing the counter after the counting finishes and the timer shows '0' or while the counter is counting?

from countdownview.

mitchhankins01 avatar mitchhankins01 commented on August 28, 2024

I would prefer while it is counting, because I implement it in a workout app. Do it counts down for rest, sometimes you don't want to rest but move to the new exercise.

Thanks for taking a request so detailed. I'd like to PayPal you to buy some coffee if you have it!

from countdownview.

mitchhankins01 avatar mitchhankins01 commented on August 28, 2024

Do = so

from countdownview.

tolgahan-arikan avatar tolgahan-arikan commented on August 28, 2024

Oh I see. Makes sense. Thank you for the thought but I can't use Paypal since I live in Turkey and your interest in the project is enough for me 👍

from countdownview.

mitchhankins01 avatar mitchhankins01 commented on August 28, 2024

Awesome :) also id like to make another suggestion. It'd also be cool to change the colors. A black background with white text for example would look really cool. Just thought I'd mention it

from countdownview.

tolgahan-arikan avatar tolgahan-arikan commented on August 28, 2024

Sure, the api is already public but I didn't have time to write a proper README, I will update the README file with the changes.

from countdownview.

mitchhankins01 avatar mitchhankins01 commented on August 28, 2024

Hi @tolgaarikan
Just wanted to let you know I just updated to the new version

I cannot dismiss the timer; but there might be a bigger problem. When the timer ends, the program crashes with a "fatal error: unexpectedly found nil while unwrapping an Optional value" error.

The problem seems to be in CountdownView.swift at line 286

I am calling the function as:

CountdownView.show(countdownFrom: programExerciseRest, spin: true, animation: CountdownView.Animation.zoomIn, autoHide: true, completion: nil)

from countdownview.

tolgahan-arikan avatar tolgahan-arikan commented on August 28, 2024

Hi @IronCoderXYZ,
I will update the README today about the new changes, but for now you can see the example project to find out how to use dismissing.
Thank you for bug report. I didn't have much time to test it out. I will be fixing that today as well.

from countdownview.

tolgahan-arikan avatar tolgahan-arikan commented on August 28, 2024

Hi @IronCoderXYZ,

If you don't have any problems I will close the issue.

from countdownview.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.