some one already changed it here for some reason: <div class="Bo

bug in the onion code, with local LAN you can never get self UDP connection status,about toktok/c-toxcore

zoff99 commented on August 16, 2024

c-toxcore/toxcore/DHT.c

Line 2942 in 172f279

if (dht_non_lan_connected(dht)) {

also because of this line we would bootstrap endlessly when only connected to LAN nodes?

from c-toxcore.

zoff99 commented on August 16, 2024

some one already changed it here for some reason:

c-toxcore/toxcore/onion_client.c

Lines 323 to 324 in 172f279

    
           // if (dht_non_lan_connected(onion_c->dht)) { 
        
           if (dht_isconnected(onion_c->dht)) {

Use TCP paths when UDP is not connected. Made some code depend less on the UDP only DHT.
450ad2d

from c-toxcore.

nurupo commented on August 16, 2024

you can never reach self UDP connection status.
but friends will get UDP connection status.

The connection status of this instance and the connection status of friends mean different things, which is mentioned in the API documentation, so this case is not surprising:

c-toxcore/toxcore/tox.h

Lines 1021 to 1029 in 172f279

    
               /** 
        
                * @brief A UDP connection has been established. 
        
                * 
        
                * For the own instance, this means it is able to send UDP packets to DHT 
        
                * nodes, but may still be connected to a TCP relay. For a friend, this 
        
                * means that the connection to that particular friend was built using 
        
                * direct UDP packets. 
        
                */ 
        
               TOX_CONNECTION_UDP,

Looking at the code bits you quoted, it looks like Tox (via the Onion module) considers the case when DHT is connected only to LAN nodes, or no nodes at all, as Tox not being connected to the DHT via UDP. To rephrase this, Tox is connected via UDP only if its DHT is connected to a non-LAN, i.e. Internet, node. This is not a bad assumption in the context of trying to connect to the greater DHT that is on the Internet, as perhaps the router NAT is preventing you from establishing UDP connections with Internet nodes, which is why you are only able to connect to LAN nodes. It's reasonable to say that you are not connected to the DHT via UDP in this case. However, if your intent was never to connect to the Internet DHT, if it was to use Tox on LAN instead, then yes, reporting that DHT is not UDP-connected is misleading. It is not UDP-connected to Internet nodes, but is UDP-connected to LAN nodes. I wonder if we need an extra flag in the connection status to indicate LAN/non-LAN connection status? Or at the very least we could clarify the documentation to say something like "A UDP connection to a non-LAN Internet node has been established.".

also because of this line we would bootstrap endlessly when only connected to LAN nodes?

Again, if your intent is to connect to the Internet DHT nodes, then there is nothing wrong with such behavior. But if you intend to use Tox only for LAN, then you wouldn't want this behavior, as you pointed out. I guess Tox wasn't designed with LAN-only use-case in mind.

from c-toxcore.

bug in the onion code, with local LAN you can never get self UDP connection status about c-toxcore HOT 3 OPEN

Comments (3)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	// if (dht_non_lan_connected(onion_c->dht)) {
	if (dht_isconnected(onion_c->dht)) {

	/**
	* @brief A UDP connection has been established.
	*
	* For the own instance, this means it is able to send UDP packets to DHT
	* nodes, but may still be connected to a TCP relay. For a friend, this
	* means that the connection to that particular friend was built using
	* direct UDP packets.
	*/
	TOX_CONNECTION_UDP,