Video corruption: Don't drop video keyframes about c-toxcore HOT 14 CLOSED

For anyone watching, I'm not sure keyframes are that important anymore.

And either way, there's a lot more work than just this one issue.

from c-toxcore.

@isotoxin i am trying to tweak c-toxcore video. can you help me?
are there windows binaries for isotoxin?
contact me please

from c-toxcore.

@mannol Please help

from c-toxcore.

@GrayHatter Why keyframes are not important? Video and so will be broken?

from c-toxcore.

Isotoxin currently uses lossless video transferring (only Isotoxin-Isotoxin calls, obviously), so it usable to share huge resolution desktop with good quality.
Lossy video transfering is horrible. A fortiori, lossy way of toxcore. Do you think toxcore lossy is just sending without confirmation of sending was successful? No way! Toxcore lossy is DON'T SEND PACKET WHEN SENDING QUEUE IS FULL! What a terrible solution...

from c-toxcore.

@alexeysvrv sending JUST keyframes isn't the issue. The problem is toxav doesn't try to recover from a high data loss event, or temporary network instability. It's currently a 'dumb' protocol, that tries it's best, and never adapts.

Fixing the sending of just keyframes will solve a single issue, one that's not often reported. That is to say, if we magically never drop a keyframe, video quality will still be problematic.

from c-toxcore.

@GrayHatter What is the solution?

from c-toxcore.

@alexeysvrv make ToxAV smarter. I was more verbose in #232

from c-toxcore.

@GrayHatter Are you doing this? You had a branch with the progress of the fix video

from c-toxcore.

I had a branch with some experimental changes, but I abandoned it because I didn't like that method once I started.

I didn't do anything remotely like my current suggestion, and the newest toxav branch I have tries to switch from VPX to a newer codec, (that doesn't work)

from c-toxcore.

@GrayHatter You try to fix it? There is time to do this?

from c-toxcore.

I'll have time eventually, but it's not likely I'll have the time within the next few months.

from c-toxcore.

@zoff99 careful with isotoxin. It's adds in a lot of extra magic that's not cross compatible with toxcore. Granted most of it probably should be in toxcore, but...

/me shrugs.

I'd be happy to help out with ToxAV if you need help. #utox on freenode with questions.

from c-toxcore.

I think this was fixed by zoff before.

from c-toxcore.